Review main Abandoned

75395[TASK] Added type hints to makeInstance

JAKOTA Design Group GmbH CR 0 V 0 Nightmare +4698 −1447 updated 08/08/22, 16:05

Commit message

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 685

Show 665 more files

Review log 810

  1. JAKOTA Design Group GmbH uploaded patch set 1 08/08/22, 13:33

  2. core-ci voted on patch set 1 V -1 08/08/22, 13:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29956

  3. Oliver Klee commented on patch set 1 CR -1 08/08/22, 15:07

    Thanks for this contribution! However, this is not needed - the generics annotations on makeInstance already provide this information to PHPStan and PhpStorm.
  4. JAKOTA Design Group GmbH uploaded patch set 2 08/08/22, 15:16

  5. core-ci voted on patch set 2 V -1 08/08/22, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29957

  6. Oliver Klee commented on patch set 2 CR -1 08/08/22, 15:28

    Reply

    This is still valid.
  7. JAKOTA Design Group GmbH commented on patch set 2 08/08/22, 15:46

    Reply

    Which makes PhpStorm a de facto requirement? I'm using VSCode and generic types are a bit of a pain at the moment. Sorry didn't notice your commend earlier.
  8. Oliver Klee commented on patch set 2 08/08/22, 15:59

    Reply

    In general, any IDE that recognizes PHP generics should be fine (although the only hard requirement is PHPStan, and PhpStorm is really prevalent among TYPO3 developers).
  9. JAKOTA Design Group GmbH commented on patch set 2 08/08/22, 16:05

    Reply

    Ack
  10. JAKOTA Design Group GmbH abandoned the change 08/08/22, 16:05