Review main Merged

75396[TASK] Raise "typo3/class-alias-loader"

Stefan Bürk CR +2 V +2 Easy +11 −11 updated 08/09/22, 08:59

Commit message

This patch raises "typo3/class-alias-loader" which
contains some bugfixes.

Used commands:

> composer req "typo3/class-alias-loader":"^1.1.4" \
  --no-update -d typo3/sysext/core
> composer req "typo3/class-alias-loader":"^1.1.4"

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Stefan Bürk uploaded patch set 1 08/08/22, 19:06

  2. core-ci voted on patch set 1 V +1 08/08/22, 19:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29962

  3. Oliver Klee commented on patch set 1 08/08/22, 20:25

    Was adding this package as a new requirement to EXT:backend and EXT:frontend (that didn't have this requirement before) intentional? If so, why?
  4. Christian Kuhn voted on patch set 1 V +1 CR +1 08/09/22, 07:25

  5. Oliver Klee commented on patch set 1 08/09/22, 08:11

    Reply

    This is not resolved yet.
  6. Stefan Bürk uploaded patch set 2 08/09/22, 08:20

  7. Stefan Bürk commented on patch set 2 08/09/22, 08:22

    Reply

    Read the output of grep wrong. However, EXT:backend and EXT:frontend defins class alias maps through composer.json (which has been found by my grep), but the require is only on core. Reverted that.
  8. core-ci voted on patch set 2 V +1 08/09/22, 08:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29970

  9. Oliver Klee commented on patch set 2 CR +1 08/09/22, 08:52

    Thanks!
  10. Benni Mack voted on patch set 2 V +2 CR +2 08/09/22, 08:59

  11. Benni Mack merged patch set 3 08/09/22, 08:59