75401[BUGFIX] Avoid workspace field query for non workspaced table
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Chris Müller +1
- Christian Kuhn +1
- Oliver Hader +1
- Thomas Löffler +1
- Benni Mack +1
-
Verified V +2 Done
- Stefan Bürk +2
- Chris Müller +1
- Christian Kuhn +1
- Benni Mack +1
- core-ci +1 CI
Issues 2
Files 83
- typo3/sysext/core/Classes/DataHandling/Localization/DataMapProcessor.php2+4 −3
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesModify/DataSet/changeHotelSortingWithOfferNotWorkspaceAware.csvdeleted+0 −60
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/WorkspacesModify/ActionTest.php+0 −27
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignField/AbstractActionWorkspacesTestCase.php1+0 −6
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/DataSet/ImportDefault.csvnew+49 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/DataSet/ImportDefaultWorkspaces.csvnew+57 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/changeParentContentSorting.csvnew+48 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/copyPage.csvnew+81 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/copyPageWHotelBeforeParentContent.csvnew+81 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/copyParentContent.csvnew+55 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/copyParentContentToDifferentPage.csvnew+55 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/copyParentContentToLanguageWAllChildren.csvnew+57 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/createNCopyParentContentNHotelNOfferChildren.csvnew+58 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csvnew+63 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/createNLocalizeParentContentNHotelNOfferChildrenWOSortBy.csvnew+63 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/createParentContent.csvnew+49 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/createParentContentNHotelNOfferChildren.csvnew+53 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/deletePage.csvnew+33 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/deleteParentContent.csvnew+45 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/inlineLocalizeSynchronizeLocalizeMissing.csvnew+93 −0
Show 63 more files
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizeNCopyPageWSynchronization.csvnew+91 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizePageAddMonoglotHotelChildNCopyPageWSynchronization.csvnew+97 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizePageNAddHotelChildWExclude.csvnew+58 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizePageNAddHotelChildWSynchronization.csvnew+58 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizePageNAddMonoglotHotelChildWSynchronization.csvnew+56 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizePageTwiceWExclude.csvnew+58 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizePageWExclude.csvnew+53 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizePageWithSynchronizationAndCustomLocalizedHotel.csvnew+55 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizePageWSynchronization.csvnew+53 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizeParentContentChainLanguageSynchronizationSource.csvnew+82 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizeParentContentNCreateNestedChildrenWLanguageSynchronization.csvnew+76 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizeParentContentSynchronization.csvnew+61 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/localizeParentContentWAllChildren.csvnew+61 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/modifyOnlyHotelChild.csvnew+48 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/modifyPage.csvnew+48 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/modifyParentContent.csvnew+48 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/modifyParentNAddHotelChild.csvnew+50 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/modifyParentNChangeHotelChildrenSorting.csvnew+48 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/modifyParentNDeleteHotelChild.csvnew+45 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/modifyParentNHotelChild.csvnew+48 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/moveParentContentToDifferentPage.csvnew+48 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/DataSet/moveParentContentToDifferentPageNChangeSorting.csvnew+48 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/Modify/ActionTest.phpnew+407 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/changeParentContentSorting.csvnew+60 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/copyPage.csvnew+64 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/copyPageWHotelBeforeParentContent.csvnew+64 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/copyParentContent.csvnew+59 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/copyParentContentToDifferentPage.csvnew+59 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/createNCopyParentContentNHotelNOfferChildren.csvnew+40 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/createNLocalizeParentContentNHotelNOfferChildren.csvnew+62 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/createNLocalizeParentContentNHotelNOfferChildrenWOSortBy.csvnew+62 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/createParentContent.csvnew+58 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/createParentContentNHotelNOfferChildren.csvnew+58 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/deletePage.csvnew+59 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/deleteParentContent.csvnew+59 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/inlineLocalizeSynchronizeLocalizeMissing.csvnew+87 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/localizeParentContentWAllChildren.csvnew+61 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/modifyNDiscardNModifyParentWHotelChild.csvnew+41 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/modifyOnlyHotelChild.csvnew+57 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/modifyPage.csvnew+59 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/modifyParentContent.csvnew+59 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/modifyParentNAddHotelChild.csvnew+59 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/modifyParentNChangeHotelChildrenSorting.csvnew+60 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/modifyParentNDeleteHotelChild.csvnew+60 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/modifyParentNHotelChild.csvnew+60 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/moveParentContentToDifferentPage.csvnew+60 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/moveParentContentToDifferentPageNChangeSorting.csvnew+42 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/DataSet/moveParentContentToDifferentPageTwice.csvnew+41 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/WorkspacesModify/ActionTest.phpnew+297 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/AbstractActionTestCase.phpnew+521 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/IrreForeignFieldNonWs/AbstractActionWorkspacesTestCase.phpnew+70 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/AbstractDataHandlerActionTestCase.php1+2 −2
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/Configuration/FlexForms/tt_content_flexform.xmlnew+33 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/Configuration/TCA/Overrides/pages.phpnew+35 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/Configuration/TCA/Overrides/tt_content.phpnew+53 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/Configuration/TCA/tx_testirreforeignfieldnonws_hotel.phpnew+114 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/Configuration/TCA/tx_testirreforeignfieldnonws_offer.phpnew+114 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/Configuration/TCA/tx_testirreforeignfieldnonws_price.phpnew+107 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/Resources/Private/Language/locallang_db.xlfnew+74 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/Resources/Public/Icons/Extension.svgnew+1 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/ext_emconf.phpnew+22 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/ext_tables.phpnew+11 −0
- typo3/sysext/core/Tests/Functional/Fixtures/Extensions/test_irre_foreignfield_non_ws/ext_tables.sqlnew+37 −0
Review log 2531
Show 56 earlier messages
-
Stefan Bürk uploaded patch set 1 08/09/22, 11:54
-
core-ci voted on patch set 1 V -1 08/09/22, 12:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29972
-
Stefan Bürk uploaded patch set 2 08/09/22, 12:04
-
Chris Müller commented on patch set 1 08/09/22, 12:05
When applying this patch, the problem is gone for a TCA configuration with no workspaces. But when I store another record which workspaces enabled I got now this error: PHP Warning: Array to string conversion in /var/www/html/vendor/typo3/cms-core/Classes/Database/Query/Expression/CompositeExpression.php line 166 -
Chris Müller commented on patch set 2 08/09/22, 12:06
Reply
Okay, seems to be gone with patchset 2. Was too quick, I assume ;-) -
Stefan Bürk commented on patch set 2 08/09/22, 12:07
Reply
yeah - was the last " lets avoid tenary for it". See second patchset, this should work completly.
-
core-ci voted on patch set 2 V +1 08/09/22, 12:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29973
-
Stefan Bürk commented on patch set 2 08/09/22, 12:15
Reply
Done -
Chris Müller voted on patch set 2 V +1 CR +1 08/09/22, 12:16
-
Christian Kuhn commented on patch set 2 08/09/22, 13:22
it was me who introduced the bug. as punishment, i'll try to come up with a functional test extension that delivers a non-ws-aware table and will add some tests. -
Thomas Löffler voted on patch set 2 CR +1 08/09/22, 15:24
-
Christian Kuhn commented on patch set 2 CR -1 08/09/22, 16:33
the fix is good, but i'll temp -1 this patch in order to add some tests. will push something today. -
Christian Kuhn commented on patch set 2 08/09/22, 21:20
ok, will push not today but tomorrow, but i reproduced locally already and i'm setting up test cases now ... -
Christian Kuhn uploaded patch set 3 08/11/22, 12:08
-
core-ci voted on patch set 3 V -1 08/11/22, 12:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30039
-
Christian Kuhn uploaded patch set 4 08/11/22, 12:19
-
Christian Kuhn commented on patch set 4 08/11/22, 12:21
AbstractDataHandlerActionTestCase.php:215that's a drive-by: you must not call $this in a static closure.AbstractActionWorkspacesTestCase.php:28this one is covered by the full-new scenario. -
Christian Kuhn updated the commit message in patch set 5 08/11/22, 12:24
-
core-ci voted on patch set 4 V +1 08/11/22, 12:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30040
-
core-ci voted on patch set 5 V +1 08/11/22, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30041
-
Andreas Kienast commented on patch set 5 CR -1 08/11/22, 12:33
DataMapProcessor.php:912Left-over debug foo? -
Christian Kuhn commented on patch set 5 08/11/22, 12:38
DataMapProcessor.php:912Replythx! -
Christian Kuhn uploaded patch set 6 08/11/22, 12:38
-
core-ci voted on patch set 6 V +1 08/11/22, 12:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30042
-
Christian Kuhn voted on patch set 6 V +1 CR +1 08/11/22, 12:48
-
Chris Müller voted on patch set 6 V +1 CR +1 08/11/22, 13:14
-
Thomas Löffler voted on patch set 6 CR +1 08/11/22, 14:11
-
Benni Mack voted on patch set 6 V +1 CR +1 08/11/22, 15:08
-
Stefan Bürk commented on patch set 6 V +2 CR +2 08/11/22, 15:23
@lolli Thank you for the tests ! -
Stefan Bürk merged patch set 7 08/11/22, 15:24
-
Oliver Hader voted on patch set 7 CR +1 08/12/22, 17:35