Review 11.5 Abandoned

75403[BUGFIX] Fix typolink regression when using nested parameter

Tomek Woldański CR 0 V 0 Easy +26 −1 updated 08/11/22, 16:07

Commit message

TypoLinkCodecService double encodes $linkParameterParts' result in quotes when parameter is nested
For example when fetching value of typolink from some field, therefore breaking further typolink parsing.

Patch fixes generating urls when using nested parameter, instead of url of i.e. "https://typo3.com _blank"
typolink handler will return "https://typo3.com" as it should

Review

  • Code review CR 0
  • Verified V 0

Issues 3

Files 2

Review log 89

  1. Tomek Woldański uploaded patch set 1 08/09/22, 16:35

  2. core-ci voted on patch set 1 V +1 08/09/22, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29978

  3. Oliver Klee commented on patch set 1 08/09/22, 17:42

    main is not affected?
  4. Łukasz Uznański commented on patch set 1 CR +1 08/10/22, 09:30

    as far as I know this does not happen on master branch
  5. Oliver Klee commented on patch set 1 08/10/22, 10:32

    Reply

    Ack
  6. Oliver Hader commented on patch set 1 CR -2 08/10/22, 18:16

    There is https://review.typo3.org/q/I22010983886a8da8a339aa6376d36303f3b729b2 - the back-port for 11.5 was missing. I guess this very change can be dropped?
  7. Tomek Woldański commented on patch set 1 08/11/22, 14:06

    Reply

    Hi, after merging https://review.typo3.org/c/Packages/TYPO3.CMS/+/75366 into 11.5 my patch can be dropped
  8. Stefan Bürk commented on patch set 1 08/11/22, 16:07

    Reply

    75366 has been merged. Will abandon this patch then. Hope this is okay.
  9. Stefan Bürk abandoned the change 08/11/22, 16:07