Review main Merged

75407[TASK] Extract url generation in ext:workspaces

Tomek Woldański CR +2 V +2 Easy +8 −2 updated 08/10/22, 15:39

Commit message

Patch extracts generating url for workspaces
in order to better integrate with external extensions,
so when external extension want to replace url,
extension does not have to override whole handleRequest method.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Łukasz Uznański +1
  • Verified V +2 Done
    • Benni Mack +2
    • Łukasz Uznański +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 78

  1. Tomek Woldański uploaded patch set 1 08/10/22, 08:43

  2. core-ci voted on patch set 1 V +1 08/10/22, 08:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/29999

  3. Łukasz Uznański voted on patch set 1 V +1 CR +1 08/10/22, 09:29

  4. Stefan Bürk commented on patch set 1 08/10/22, 14:49

    Maybe would be wise to thing about adding a usefull event (feature) afterwards for main, so that extensions do not have to override the class at all ?
  5. Benni Mack commented on patch set 1 V +2 CR +2 08/10/22, 15:01

    Reply

    yes. will take care separately
  6. Benni Mack merged patch set 2 08/10/22, 15:01

  7. Simon Schaufelberger commented on patch set 2 08/10/22, 15:15

    Somebody overlooked that the release line Releases: master, 11.5 is invalid and outdated...
  8. Benni Mack commented on patch set 2 08/10/22, 15:39

    Reply

    yes. that was me. sorry