Review main Merged

75409[DOCS] Fix typo in title and filename

TYPO3com CR +2 V +2 Easy +5 −5 updated 08/11/22, 16:31

Commit message

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
    • Oliver Klee +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 1216

  1. TYPO3com uploaded patch set 1 08/10/22, 10:58

  2. core-ci voted on patch set 1 V +1 08/10/22, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30002

  3. Chris Müller commented on patch set 1 CR -1 08/10/22, 11:06

    AFAIK the "=" for the header must be at least the length of the text. Will take care later. I am not sure, if we should change the filename, as it is already in search engines.
  4. Stefan Bürk commented on patch set 1 08/10/22, 14:41

    Reply

    I would say we should correct this. Maybe we have to talk with the documentation team if they may provide an redirect then.

    Breaking-92118-TCACtrlThumbnailSettingDropped.rst:3

    should be extended by one = then (same length as title) same for line below Think that was what Chris already mentioned.
  5. Chris Müller uploaded patch set 2 08/10/22, 16:28

  6. Chris Müller commented on patch set 2 08/10/22, 16:29

    Breaking-92118-TCACtrlThumbnailSettingDropped.rst:3 Reply

    Done
  7. core-ci voted on patch set 2 V +1 08/10/22, 16:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30024

  8. Chris Müller voted on patch set 2 V +1 CR +1 08/10/22, 17:08

  9. Stefan Bürk commented on patch set 2 08/10/22, 17:57

    Should this not be backported at to 11.5 ?
  10. Chris Müller updated the commit message in patch set 3 08/11/22, 08:01

  11. Chris Müller commented on patch set 3 08/11/22, 08:01

    Reply

    Done
  12. core-ci voted on patch set 3 V +1 08/11/22, 08:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30035

  13. Chris Müller voted on patch set 3 V +1 CR +1 08/11/22, 08:12

  14. Oliver Klee voted on patch set 3 V +1 CR +1 08/11/22, 09:51

  15. Stefan Bürk voted on patch set 3 V +2 CR +2 08/11/22, 16:31

  16. Stefan Bürk merged patch set 4 08/11/22, 16:31