Review main Merged

75412[BUGFIX] Allow non-valid absolute paths for createVersionNumberFileName

Benni Mack CR +2 V +2 Normal +52 −4 updated 08/10/22, 15:05

Commit message

With the fix of using versioned numbered filenames for the
TYPO3 Backend, a use-case "absolutely referenced, but
relative to public path file" did break for Frontend
inclusions of CSS or JS files.

This is now overcome by only using the original bugfix in the TYPO3
Backend.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 67

  1. Benni Mack uploaded patch set 1 08/10/22, 12:42

  2. core-ci voted on patch set 1 V +1 08/10/22, 12:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30009

  3. Oli Bartsch commented on patch set 1 V +1 CR +1 08/10/22, 13:26

    GeneralUtility.php:2136

    I assume you did the elseif to make it clear that those are two different use cases. Otherwise this could just be done in one if using an OR operator.
  4. Benni Mack commented on patch set 1 08/10/22, 13:35

    GeneralUtility.php:2136 Reply

    exactly, so we have the comment. In the future, we need to adopt this line (in general) or even move the code somewhere else.
  5. Stefan Bürk voted on patch set 1 V +1 CR +1 08/10/22, 14:21

  6. Benni Mack voted on patch set 1 V +2 CR +2 08/10/22, 15:05

  7. Benni Mack merged patch set 2 08/10/22, 15:05