Review 11.5 Merged

75415[BUGFIX] Reflect size property to attribute in icon-element

Helmut Hummel CR +2 V +2 Easy +5 −5 updated 08/12/22, 20:10

Commit message

When using the custom element <typo3-backend-icon>
with a JS framework, that renders the DOM (e.g. Vue),
it can happen, that they set the properties of the custom element
instead of an attribute.

Since Lit does not reflect these properties to attributes by default,
but the icon-element relies on CSS set on the host element that depends
on the size attribute, the icon is not rendered in the correct size.

See: https://web.dev/custom-elements-best-practices/
on why reflecting properties to attributes might be a good idea
in some cases.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Anja Leichsenring +1
    • Oliver Hader +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • Anja Leichsenring +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Helmut Hummel uploaded patch set 1 08/10/22, 23:09

  2. core-ci voted on patch set 1 V +1 08/10/22, 23:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30029

  3. Benjamin Franzke uploaded patch set 2 08/11/22, 06:25

  4. core-ci voted on patch set 2 V +1 08/11/22, 06:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30034

  5. Oliver Hader voted on patch set 2 CR +1 08/11/22, 07:01

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 08/12/22, 19:55

  7. Stefan Bürk voted on patch set 2 V +2 CR +2 08/12/22, 20:10

  8. Stefan Bürk merged patch set 3 08/12/22, 20:10