Review 11.5 Merged

75418[BUGFIX] Avoid workspace field query for non workspaced table

Christian Kuhn CR +2 V +2 Easy +4 −3 updated 08/11/22, 15:24

Commit message

With #97989 correct workspace overlays in DataMapProcessor
should be used to fix a bug. This introduced a failing default
"where" if a child table is not workspace aware.

The fix itself is straight forward: Query t3ver_wsid field
only if the target table is workspace aware.

In contrast to the TYPO3 v12 (main) version, the v11 backport
delivers just the code change, since functional test structures
have been modernized a lot in v12 already.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
    • Oli Bartsch +1
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Chris Müller +1
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 08/11/22, 12:55

  2. core-ci voted on patch set 1 V +1 08/11/22, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30043

  3. Chris Müller voted on patch set 1 V +1 CR +1 08/11/22, 13:14

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 08/11/22, 14:10

  5. Oliver Klee voted on patch set 1 CR +1 08/11/22, 14:11

  6. Stefan Bürk voted on patch set 1 V +2 CR +2 08/11/22, 15:24

  7. Stefan Bürk merged patch set 2 08/11/22, 15:24