Review main Merged

75423[TASK] Remove obsolete `.t3-icon` class

Andreas Kienast CR +2 V +2 Easy +3 −42 updated 08/12/22, 18:36

Commit message

As FontAwesome was removed and all icons are rendered via the Icon API
now, the CSS class `.t3-icon` became obsolete and is now removed.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Benjamin Franzke +1
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • Benni Mack +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Stefan Bürk +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1315

  1. Andreas Kienast uploaded patch set 1 08/12/22, 08:05

  2. Andreas Kienast wrote 08/12/22, 08:06

    Topic set to icons
  3. core-ci voted on patch set 1 V +1 08/12/22, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30065

  4. Benjamin Franzke commented on patch set 1 08/12/22, 08:40

    Looks good in general. What about these cases? git grep t3-icon Build/Sources/Sass/component/_avatar.scss:// <span class="t3-icon t3-icon-status t3-icon-status-user t3-icon-user-admin"></span> Build/Sources/Sass/typo3/_element_docheader.scss: .t3-icon { Build/Sources/Sass/typo3/_element_docheader.scss: .t3-icon { Build/Sources/Sass/typo3/_element_docheader.scss: .t3-icon { Build/Sources/Sass/typo3/_element_pagination.scss: .t3-icon { Build/Sources/Sass/typo3/_element_table.scss:// <span class="t3-icon t3-icon-treeline t3-icon-treeline-join t3-icon-join">&nbsp;</span> Build/Sources/Sass/typo3/_element_table.scss: .t3-icon { Build/Sources/Sass/typo3/_main_form.scss: .t3-icon {
  5. Andreas Kienast commented on patch set 1 08/12/22, 08:55

    Reply

    Thanks, obviously I didn't check the Build folder. My gut feeling says they are obsolete as well, but let's check that in detail.
  6. Andreas Kienast uploaded patch set 2 08/12/22, 10:00

  7. core-ci voted on patch set 2 V +1 08/12/22, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30072

  8. Andreas Kienast commented on patch set 2 08/12/22, 10:11

    _main_form.scss:164

    I couldn't find any possible usage for this one that could've needed migration, so I dropped it completely.
  9. Benjamin Franzke voted on patch set 2 CR +1 08/12/22, 10:40

  10. Benni Mack voted on patch set 2 CR +1 08/12/22, 10:46

  11. Nikita Hovratov commented on patch set 2 V +1 CR +1 08/12/22, 16:09

    _main_form.scss:164 Reply

    Ack
  12. Anja Leichsenring voted on patch set 2 V +1 CR +1 08/12/22, 18:35

  13. Stefan Bürk voted on patch set 2 V +1 CR +1 08/12/22, 18:36

  14. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/12/22, 18:36

  15. Anja Leichsenring merged patch set 3 08/12/22, 18:36