75423[TASK] Remove obsolete `.t3-icon` class
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Benjamin Franzke +1
- Stefan Bürk +1
- Nikita Hovratov +1
- Benni Mack +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Stefan Bürk +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 8
- Build/Sources/Sass/component/_avatar.scss+2 −2
- Build/Sources/Sass/typo3/_element_docheader.scss+0 −12
- Build/Sources/Sass/typo3/_element_pagination.scss+0 −4
- Build/Sources/Sass/typo3/_element_table.scss+0 −7
- Build/Sources/Sass/typo3/_icons.scss+0 −12
- Build/Sources/Sass/typo3/_main_form.scss2+0 −4
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/Icons/icon_fatalerror.gifdeletedbinary
Review log 1315
-
Andreas Kienast uploaded patch set 1 08/12/22, 08:05
-
Andreas Kienast wrote 08/12/22, 08:06
Topic set to icons -
core-ci voted on patch set 1 V +1 08/12/22, 08:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30065
-
Benjamin Franzke commented on patch set 1 08/12/22, 08:40
Looks good in general. What about these cases? git grep t3-icon Build/Sources/Sass/component/_avatar.scss:// <span class="t3-icon t3-icon-status t3-icon-status-user t3-icon-user-admin"></span> Build/Sources/Sass/typo3/_element_docheader.scss: .t3-icon { Build/Sources/Sass/typo3/_element_docheader.scss: .t3-icon { Build/Sources/Sass/typo3/_element_docheader.scss: .t3-icon { Build/Sources/Sass/typo3/_element_pagination.scss: .t3-icon { Build/Sources/Sass/typo3/_element_table.scss:// <span class="t3-icon t3-icon-treeline t3-icon-treeline-join t3-icon-join"> </span> Build/Sources/Sass/typo3/_element_table.scss: .t3-icon { Build/Sources/Sass/typo3/_main_form.scss: .t3-icon { -
Andreas Kienast commented on patch set 1 08/12/22, 08:55
Reply
Thanks, obviously I didn't check the Build folder. My gut feeling says they are obsolete as well, but let's check that in detail. -
Andreas Kienast uploaded patch set 2 08/12/22, 10:00
-
core-ci voted on patch set 2 V +1 08/12/22, 10:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30072
-
Andreas Kienast commented on patch set 2 08/12/22, 10:11
_main_form.scss:164I couldn't find any possible usage for this one that could've needed migration, so I dropped it completely. -
Benjamin Franzke voted on patch set 2 CR +1 08/12/22, 10:40
-
Benni Mack voted on patch set 2 CR +1 08/12/22, 10:46
-
Nikita Hovratov commented on patch set 2 V +1 CR +1 08/12/22, 16:09
_main_form.scss:164ReplyAck -
Anja Leichsenring voted on patch set 2 V +1 CR +1 08/12/22, 18:35
-
Stefan Bürk voted on patch set 2 V +1 CR +1 08/12/22, 18:36
-
Anja Leichsenring voted on patch set 2 V +2 CR +2 08/12/22, 18:36
-
Anja Leichsenring merged patch set 3 08/12/22, 18:36