Review main Merged

75425[FEATURE] Allow icon deprecation in extensions

Andreas Kienast CR +2 V +2 Normal +67 −11 updated 08/12/22, 19:50

Commit message

Until now, icon deprecation wasn't possible for extensions as the
deprecation handling is internal to the IconRegistry. A new option
`deprecated` is introduced that may contain the following data:

* `since` - since when is the icon deprecated
* `until` - when will the icon be removed
* `replacement` - if given, an alternative icon is offered

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1519

  1. Andreas Kienast uploaded patch set 1 08/12/22, 09:07

  2. Andreas Kienast wrote 08/12/22, 09:09

    Topic set to icons
  3. core-ci voted on patch set 1 V +1 08/12/22, 09:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30068

  4. Andreas Kienast uploaded patch set 2 08/12/22, 10:10

  5. core-ci voted on patch set 2 V +1 08/12/22, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30073

  6. Chris Müller commented on patch set 2 08/12/22, 11:58

    I also tried "deprecation => true" which works fine. But I think we should not promote this.

    Feature-98130-AllowDeprecationOfIconsInExtensions.rst:27

    Perhaps we should write "TYPO3 deprecation log"?
  7. Andreas Kienast commented on patch set 2 08/12/22, 12:23

    Reply

    Yep, that's the intentional fallback if all options are omitted. I agree this shouldn't be promoted :-).

    Feature-98130-AllowDeprecationOfIconsInExtensions.rst:27 Reply

    Ack
  8. Andreas Kienast uploaded patch set 3 08/12/22, 12:24

  9. core-ci voted on patch set 3 V +1 08/12/22, 12:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30089

  10. Chris Müller voted on patch set 3 V +1 CR +1 08/12/22, 13:16

  11. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/12/22, 19:40

  12. Christian Kuhn voted on patch set 3 CR +1 08/12/22, 19:40

  13. Christian Kuhn uploaded patch set 4 08/12/22, 19:43

  14. Christian Kuhn voted on patch set 4 V +1 CR +1 08/12/22, 19:43

  15. Anja Leichsenring voted on patch set 4 V +1 CR +1 08/12/22, 19:44

  16. Stefan Bürk voted on patch set 4 V +1 CR +1 08/12/22, 19:44

  17. core-ci voted on patch set 4 V +1 08/12/22, 19:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30122

  18. Nikita Hovratov voted on patch set 4 V +2 CR +2 08/12/22, 19:50

  19. Nikita Hovratov merged patch set 5 08/12/22, 19:50