Review main Merged Breaking

75427[!!!][FEATURE] Set Symfony 6.1 as minimum requirement

Benni Mack CR +2 V +2 Expert +555 −571 updated 08/17/22, 16:09

Commit message

This change raises the used Symfony Components
to at least version Symfony 6.1.

The requirement for "typo3/symfony-psr-event-dispatcher-adapter"
is removed, as this was for support for allowing
symfony4 AND symfony5 with the same TYPO3 major version.

A few important highlights:
* Symfony DI now only accepts objects or null to be
 returned by $container->get('myService')
* Lots of typehints were added, this is mainly an issue
  if extensions extend Symfony classes
* PHP 8.1+ requirements (which we already have in place for TYPO3 v12)

See all features within Symfony 6.1:
* https://symfony.com/blog/category/living-on-the-edge/6.1

Symfony 6 is supported until November 2027 (once we
upgrade to Symfony 6 LTS, which will happen in November 2023)
unlike Symfony 5 LTS which has an EOL on November 2025.

Used commands:

> composer req composer/composer:^2.3.0 -W --dev
> composer remove typo3/symfony-psr-event-dispatcher-adapter
> composer remove --no-update -d typo3/sysext/core \
    typo3/symfony-psr-event-dispatcher-adapter
> composer req --no-update -d typo3/sysext/adminpanel \
    symfony/var-dumper:^6.1
> composer req --no-update -d typo3/sysext/core \
	psr/container:^2.0 \
	symfony/config:^6.1 \
	symfony/console:^6.1 \
	symfony/dependency-injection:^6.1 \
	symfony/event-dispatcher-contracts:^3.1 \
	symfony/expression-language:^6.1 \
	symfony/filesystem:^6.1 \
	symfony/finder:^6.1 \
	symfony/http-foundation:^6.1 \
	symfony/mailer:^6.1 \
	symfony/mime:^6.1 \
	symfony/options-resolver:^6.1 \
	symfony/rate-limiter:^6.1 \
	symfony/routing:^6.1 \
	symfony/yaml:^6.1
> composer req --no-update -d typo3/sysext/extbase \
	symfony/dependency-injection:^6.1 \
	symfony/property-access:^6.1 \
	symfony/property-info:^6.1
> composer req --no-update -d typo3/sysext/fluid \
	symfony/dependency-injection:^6.1
> composer req --no-update -d typo3/sysext/form \
	symfony/expression-language:^6.1
> composer req --no-update -d typo3/sysext/install \
	symfony/finder:^6.1 \
	symfony/http-foundation:^6.1
> composer req --no-update -d typo3/sysext/redirects \
    symfony/console:^6.1
> composer req -W \
	psr/container:^2.0 \
	symfony/config:^6.1 \
	symfony/console:^6.1 \
	symfony/dependency-injection:^6.1 \
	symfony/event-dispatcher-contracts:^3.1 \
	symfony/expression-language:^6.1 \
	symfony/filesystem:^6.1 \
	symfony/finder:^6.1 \
	symfony/http-foundation:^6.1 \
	symfony/mailer:^6.1 \
	symfony/mime:^6.1 \
	symfony/options-resolver:^6.1 \
	symfony/property-access:^6.1 \
	symfony/property-info:^6.1 \
	symfony/rate-limiter:^6.1 \
	symfony/routing:^6.1 \
	symfony/var-dumper:^6.1 \
	symfony/yaml:^6.1

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 49

Show 29 more files

Review log 2542

Show 917 earlier messages
  1. Benni Mack uploaded patch set 1 08/12/22, 10:17

  2. core-ci voted on patch set 1 V -1 08/12/22, 10:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30074

  3. Benni Mack uploaded patch set 2 08/12/22, 11:03

  4. core-ci voted on patch set 2 V -1 08/12/22, 11:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30077

  5. Benni Mack uploaded patch set 3 08/12/22, 11:27

  6. Benni Mack uploaded patch set 4 08/12/22, 11:28

  7. core-ci voted on patch set 3 V -1 08/12/22, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30079

  8. core-ci voted on patch set 4 V -1 08/12/22, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30080

  9. Benni Mack uploaded patch set 5 08/12/22, 11:45

  10. Benni Mack uploaded patch set 6 08/12/22, 11:47

  11. core-ci voted on patch set 5 V -1 08/12/22, 11:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30084

  12. core-ci voted on patch set 6 V -1 08/12/22, 12:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30086

  13. Benni Mack uploaded patch set 7 08/12/22, 12:02

  14. core-ci voted on patch set 7 V -1 08/12/22, 12:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30087

  15. Benni Mack uploaded patch set 8 08/12/22, 12:32

  16. core-ci voted on patch set 8 V -1 08/12/22, 12:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30090

  17. Stefan Bürk uploaded patch set 9 08/12/22, 12:53

  1. core-ci voted on patch set 9 V -1 08/12/22, 13:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30095

  2. Stefan Bürk uploaded patch set 10 08/12/22, 13:19

  3. Stefan Bürk uploaded patch set 11 08/12/22, 13:27

  4. core-ci voted on patch set 10 V -1 08/12/22, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30097

  5. core-ci voted on patch set 10 V -1 08/12/22, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30097

  6. core-ci voted on patch set 11 V -1 08/12/22, 13:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30099

  7. Stefan Bürk commented on patch set 11 08/12/22, 14:39

    Changes: * Build/runTests.sh -s cglGit * removed `TYPO3\SymfonyPsrEventDispatcherAdapter\EventDispatcherAdapter` alias from typo3/sysext/core/Configuration/Services.yaml * added changed require for typo3/sysext/extbase/composer.json * updated commit message to contain all executed composer commands Unit tests still failing, some DI setup in tests. Some are failing because of changes in symfony di (function returning not an object, but an integer) etc ... may be some breaking things then, meaning loosing possibilities which has been possible before.
  8. Benni Mack uploaded patch set 12 08/17/22, 09:05

  9. core-ci voted on patch set 12 V -1 08/17/22, 09:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30219

  10. Benni Mack uploaded patch set 13 08/17/22, 12:46

  11. core-ci voted on patch set 13 V +1 08/17/22, 12:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30236

  12. Oliver Klee commented on patch set 13 08/17/22, 13:31

    Services.yaml:384

    Can we drop this completely?
  13. Benni Mack commented on patch set 14 08/17/22, 13:45

    Published edit on patch set 13.
  14. Benni Mack commented on patch set 14 08/17/22, 13:46

    Services.yaml:384 Reply

    Done
  15. core-ci voted on patch set 14 V +1 08/17/22, 13:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30239

  16. Stefan Bürk commented on patch set 14 08/17/22, 15:18

  17. Stefan Bürk commented on patch set 14 08/17/22, 15:33

    Logger.php:199

    Should we not add `string|int` as native union type here ?

    Breaking-98158-UpdateToSymfony6.rst:40

    `FullyScanned` - should be `NotScanned` or ? I could not see any scanner definitions, and I think this is not really possible.
  18. Christian Kuhn voted on patch set 14 V +1 CR +1 08/17/22, 15:36

  19. core-ci commented on patch set 14 08/17/22, 15:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30243

  20. Stefan Bürk uploaded patch set 15 08/17/22, 15:52

  21. Stefan Bürk commented on patch set 15 08/17/22, 15:52

    Logger.php:199 Reply

    Done

    Breaking-98158-UpdateToSymfony6.rst:40 Reply

    Done
  22. core-ci voted on patch set 15 V +1 08/17/22, 15:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30244

  23. Stefan Bürk voted on patch set 15 V +1 CR +1 08/17/22, 15:59

  24. Christian Kuhn voted on patch set 15 V +2 CR +2 08/17/22, 16:07

  25. Christian Kuhn merged patch set 16 08/17/22, 16:09