75432[TASK] Use more native types in the blog extension
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Christian Kuhn +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 2
Files 16
- Build/phpstan/phpstan-baseline.neon+0 −30
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/BlogController.php+13 −27
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Controller/ContentController.php+13 −29
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Administrator.php+37 −275
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Blog.php+17 −94
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Category.php+5 −39
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Comment.php+11 −56
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/DateExample.php+9 −34
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/DateTimeImmutableExample.php+6 −31
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/FrontendUserGroup.php+6 −47
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Info.php+3 −19
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Person.php+19 −78
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Post.php+29 −138
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/Tag.php+2 −15
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Model/TtContent.php+12 −52
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/blog_example/Classes/Domain/Repository/PostRepository.php+7 −18
Review log 1722
-
Oliver Klee uploaded patch set 1 08/12/22, 14:50
-
Oliver Klee marked it work in progress 08/12/22, 14:53
-
Oliver Klee commented on patch set 1 08/12/22, 14:53
Marking as WIP - some functional tests are failing. -
core-ci voted on patch set 1 V -1 08/12/22, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30102
-
Oliver Klee uploaded patch set 2 08/12/22, 15:02
-
Oliver Klee marked it ready for review 08/12/22, 15:02
-
Oliver Klee uploaded patch set 3 08/12/22, 15:06
-
core-ci voted on patch set 3 V +1 08/12/22, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30104
-
Nikita Hovratov uploaded patch set 4 08/12/22, 15:47
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 08/12/22, 15:47
-
Oliver Klee uploaded patch set 5 08/12/22, 15:52
-
core-ci voted on patch set 5 V +1 08/12/22, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30106
-
core-ci voted on patch set 4 V +1 08/12/22, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30105
-
Oliver Klee commented on patch set 5 CR -1 08/12/22, 16:08
@Nikita: Sorry, I didn't see that you had pushed. I'll repush in a second with your changes included. -
Oliver Klee commented on patch set 5 08/12/22, 16:09
Reply
Done -
Oliver Klee uploaded patch set 6 08/12/22, 16:09
-
Nikita Hovratov commented on patch set 6 08/12/22, 16:10
Reply
thanks -
Nikita Hovratov voted on patch set 6 V +1 CR +1 08/12/22, 16:11
-
core-ci voted on patch set 6 V +1 08/12/22, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30107
-
Christian Kuhn voted on patch set 6 V +1 CR +1 08/12/22, 18:42
-
Anja Leichsenring voted on patch set 6 V +2 CR +2 08/12/22, 18:42
-
Anja Leichsenring merged patch set 7 08/12/22, 18:42