Review main Merged

75432[TASK] Use more native types in the blog extension

Oliver Klee CR +2 V +2 Expert +189 −982 updated 08/12/22, 18:42

Commit message

Also add a missing property that already had a getter
and setter.

Also drop redundant type annotations and comments.

Used command:
> ./Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Christian Kuhn +1
    • Nikita Hovratov +1
    • core-ci +1 CI

Issues 2

Files 16

Review log 1722

  1. Oliver Klee uploaded patch set 1 08/12/22, 14:50

  2. Oliver Klee marked it work in progress 08/12/22, 14:53

  3. Oliver Klee commented on patch set 1 08/12/22, 14:53

    Marking as WIP - some functional tests are failing.
  4. core-ci voted on patch set 1 V -1 08/12/22, 14:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30102

  5. Oliver Klee uploaded patch set 2 08/12/22, 15:02

  6. Oliver Klee marked it ready for review 08/12/22, 15:02

  7. Oliver Klee uploaded patch set 3 08/12/22, 15:06

  8. core-ci voted on patch set 3 V +1 08/12/22, 15:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30104

  9. Nikita Hovratov uploaded patch set 4 08/12/22, 15:47

  10. Nikita Hovratov voted on patch set 4 V +1 CR +1 08/12/22, 15:47

  11. Oliver Klee uploaded patch set 5 08/12/22, 15:52

  12. core-ci voted on patch set 5 V +1 08/12/22, 15:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30106

  13. core-ci voted on patch set 4 V +1 08/12/22, 16:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30105

  14. Oliver Klee commented on patch set 5 CR -1 08/12/22, 16:08

    @Nikita: Sorry, I didn't see that you had pushed. I'll repush in a second with your changes included.
  15. Oliver Klee commented on patch set 5 08/12/22, 16:09

    Reply

    Done
  16. Oliver Klee uploaded patch set 6 08/12/22, 16:09

  17. Nikita Hovratov commented on patch set 6 08/12/22, 16:10

    Reply

    thanks
  18. Nikita Hovratov voted on patch set 6 V +1 CR +1 08/12/22, 16:11

  19. core-ci voted on patch set 6 V +1 08/12/22, 16:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30107

  20. Christian Kuhn voted on patch set 6 V +1 CR +1 08/12/22, 18:42

  21. Anja Leichsenring voted on patch set 6 V +2 CR +2 08/12/22, 18:42

  22. Anja Leichsenring merged patch set 7 08/12/22, 18:42