Review main Merged

75433[TASK] Switch to dart-sass

Nikita Hovratov CR +2 V +2 Hard +140 −613 updated 08/12/22, 19:13

Commit message

node-sass respectively LibSass is deprecated as stated in
https://www.npmjs.com/package/node-sass

Since we use Bootstrap v5 since TYPO3 v11, which itself compiles with
dart-sass, the native JavaScript based sass solution, we can finally
also make the switch. This is also possible, as FontAwesome is now
dropped from the core.

The sass-migrator was used here to migrate the majority of division
operators to math.div or inverse it to a multiplication.
See: https://sass-lang.com/documentation/cli/migrator

Used commands:

> yarn remove node-sass
> yarn add sass -D
> sass-migrator division **/*.scss
> Build/Scripts/runTests.sh -s buildCss

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 33

Show 13 more files

Review log 811

  1. Nikita Hovratov uploaded patch set 1 08/12/22, 17:52

  2. core-ci voted on patch set 1 V +1 08/12/22, 18:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30109

  3. Nikita Hovratov updated the commit message in patch set 2 08/12/22, 18:07

  4. core-ci voted on patch set 2 V +1 08/12/22, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30112

  5. Nikita Hovratov uploaded patch set 3 08/12/22, 18:43

  6. core-ci voted on patch set 3 V +1 08/12/22, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30118

  7. Anja Leichsenring voted on patch set 3 V +1 CR +1 08/12/22, 19:13

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 08/12/22, 19:13

  9. Nikita Hovratov voted on patch set 3 V +2 CR +2 08/12/22, 19:13

  10. Stefan Bürk voted on patch set 3 V +1 CR +1 08/12/22, 19:13

  11. Nikita Hovratov merged patch set 4 08/12/22, 19:13