Review main Merged

75436[BUGFIX] Restore module menu collapse behaviour

Stefan Bürk CR +2 V +2 Easy +15 −2 updated 08/14/22, 23:35

Commit message

With the removal of the Font Awesome icon provider in #98089 the
corresponding scss/css styling definition for the module name
has been removed. This made it impossible to fully collapse the
module menu to icons and to a smaller size.

Bootstrap 5 replaced `.sr-only` with `.visually-hidden`. However,
this does not work for the module menu as the menu entry names
are hidden in expanded mode, thus making this a non-usable
option.
See: https://getbootstrap.com/docs/5.0/migration/#helpers
and: https://getbootstrap.com/docs/5.0/helpers/visually-hidden/

This patch re-adds scss/css styling directly for the module
menu without using the `@sr-only` or the new `.visually-hidden`
definition from bootstrap to restore the module menu collapse
behaviour.

Used commands:

> Build/Scripts/runTests.sh -s clean
> Build/Scripts/runTests.sh -s buildCss

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Andreas Kienast +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1722

  1. Stefan Bürk uploaded patch set 1 08/13/22, 09:25

  2. core-ci voted on patch set 1 V +1 08/13/22, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30137

  3. Stefan Bürk updated the commit message in patch set 2 08/13/22, 09:54

  4. core-ci voted on patch set 2 V +1 08/13/22, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30138

  5. Simon Schaufelberger commented on patch set 2 08/13/22, 10:05

    expanded mode

    _modulemenu.scss:92

    expanded state
  6. Stefan Bürk uploaded patch set 3 08/13/22, 11:51

  7. Nikita Hovratov uploaded patch set 4 08/13/22, 11:51

  8. Stefan Bürk commented on patch set 4 08/13/22, 11:53

    Reply

    Done

    _modulemenu.scss:92 Reply

    Done
  9. Nikita Hovratov voted on patch set 4 V +1 CR +1 08/13/22, 11:55

  10. core-ci voted on patch set 3 V +1 08/13/22, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30143

  11. core-ci voted on patch set 4 V +1 08/13/22, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30144

  12. Stefan Bürk commented on patch set 4 CR -1 08/13/22, 12:05

    temp -1 : want to have Andreas have a look on it.
  13. Andreas Kienast commented on patch set 4 V +1 CR -1 08/14/22, 10:03

    _modulemenu.scss:91

    IMO this doesn't belong here.

    _modulemenu.scss:97

    Is this still required?
  14. Andreas Kienast uploaded patch set 5 08/14/22, 10:23

  15. Andreas Kienast commented on patch set 5 V +1 CR +1 08/14/22, 10:28

    It works for me, I couldn't reproduce any issue with the missing "margin: -1px". Please verify if this is true in all cases.
  16. core-ci voted on patch set 5 V +1 08/14/22, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30162

  17. Simon Schaufelberger commented on patch set 5 V -1 08/14/22, 23:07

    This problem exists also on v11 already but since we are fixing this issue, we could also fix the other issue. When you collapse the menu (only icons) and reduce the height that you get a vertical scrollbar and then press f5 to reload the page, there is suddenly a horizonal scrollbar as well.
  18. Stefan Bürk commented on patch set 5 08/14/22, 23:21

    Reply

    This patch is about fixing the broken module menu, so it do not size down to icons, which only is an issue in main. The related patch which brokes this was in main only. Regarding the "vertical scrollbar" issue - we found that too, but the "margin -1" is not the solution for it. Andreas and I verified the vertical scrollbar issue with and without the `margin: -1`. So I would say, let's handle this in a dedicated patch, not in this one. Argument is, that this a) must be further investigated and b) leaving module menu for main fully broken in the meanwhile (and I'd like to avoid reverting the font awesown icon provider patch) Would this be fine for you ?
  19. Stefan Bürk commented on patch set 5 08/14/22, 23:25

    _modulemenu.scss:91 Reply

    Done

    _modulemenu.scss:97 Reply

    Does not have any effect. Okay to be removed. Done.
  20. Simon Schaufelberger commented on patch set 5 V +1 CR +1 08/14/22, 23:28

    Reply

    yes, fine for me.
  21. Stefan Bürk voted on patch set 5 V +2 CR +2 08/14/22, 23:35

  22. Stefan Bürk merged patch set 6 08/14/22, 23:35