75436[BUGFIX] Restore module menu collapse behaviour
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Andreas Kienast +1
- Simon Schaufelberger +1
-
Verified V +2 Done
- Stefan Bürk +2
- Andreas Kienast +1
- Simon Schaufelberger +1
- core-ci +1 CI
Issues 2
Files 3
Review log 1722
-
Stefan Bürk uploaded patch set 1 08/13/22, 09:25
-
core-ci voted on patch set 1 V +1 08/13/22, 09:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30137
-
Stefan Bürk updated the commit message in patch set 2 08/13/22, 09:54
-
core-ci voted on patch set 2 V +1 08/13/22, 10:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30138
-
Simon Schaufelberger commented on patch set 2 08/13/22, 10:05
expanded mode_modulemenu.scss:92expanded state -
Stefan Bürk uploaded patch set 3 08/13/22, 11:51
-
Nikita Hovratov uploaded patch set 4 08/13/22, 11:51
-
Nikita Hovratov voted on patch set 4 V +1 CR +1 08/13/22, 11:55
-
core-ci voted on patch set 3 V +1 08/13/22, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30143
-
core-ci voted on patch set 4 V +1 08/13/22, 12:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30144
-
Stefan Bürk commented on patch set 4 CR -1 08/13/22, 12:05
temp -1 : want to have Andreas have a look on it. -
Andreas Kienast commented on patch set 4 V +1 CR -1 08/14/22, 10:03
_modulemenu.scss:91IMO this doesn't belong here._modulemenu.scss:97Is this still required? -
Andreas Kienast uploaded patch set 5 08/14/22, 10:23
-
Andreas Kienast commented on patch set 5 V +1 CR +1 08/14/22, 10:28
It works for me, I couldn't reproduce any issue with the missing "margin: -1px". Please verify if this is true in all cases. -
core-ci voted on patch set 5 V +1 08/14/22, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30162
-
Simon Schaufelberger commented on patch set 5 V -1 08/14/22, 23:07
This problem exists also on v11 already but since we are fixing this issue, we could also fix the other issue. When you collapse the menu (only icons) and reduce the height that you get a vertical scrollbar and then press f5 to reload the page, there is suddenly a horizonal scrollbar as well. -
Stefan Bürk commented on patch set 5 08/14/22, 23:21
Reply
This patch is about fixing the broken module menu, so it do not size down to icons, which only is an issue in main. The related patch which brokes this was in main only. Regarding the "vertical scrollbar" issue - we found that too, but the "margin -1" is not the solution for it. Andreas and I verified the vertical scrollbar issue with and without the `margin: -1`. So I would say, let's handle this in a dedicated patch, not in this one. Argument is, that this a) must be further investigated and b) leaving module menu for main fully broken in the meanwhile (and I'd like to avoid reverting the font awesown icon provider patch) Would this be fine for you ? -
Stefan Bürk commented on patch set 5 08/14/22, 23:25
_modulemenu.scss:91ReplyDone_modulemenu.scss:97ReplyDoes not have any effect. Okay to be removed. Done. -
Simon Schaufelberger commented on patch set 5 V +1 CR +1 08/14/22, 23:28
Reply
yes, fine for me. -
Stefan Bürk voted on patch set 5 V +2 CR +2 08/14/22, 23:35
-
Stefan Bürk merged patch set 6 08/14/22, 23:35