Review main Abandoned

75440[TASK] Change handling of cache flush command

Falk Berger CR 0 V 0 Easy +1 −0 updated 08/15/22, 07:02

Commit message

This patch changes the way the cache flush command
of the apcu backend works. It simply needs less
meta information in the cache itself.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Falk Berger uploaded patch set 1 08/13/22, 11:47

  2. core-ci voted on patch set 1 V +1 08/13/22, 11:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30142

  3. Oliver Klee commented on patch set 1 08/13/22, 12:01

    Is 11.5 also affected? (And I assume that this is not a critical bug fix, hence it should not go into 10.4.)
  4. Stefan Bürk commented on patch set 1 CR -1 08/15/22, 06:57

    I think there went something wrong. It seems, that this is the "add missing use statement" for the original patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/75438 to get the "pipeline" green, this having now the relation chain. The changes was not properly amended to the other patch. Will add this there and abandon this patch than. Please have a look into the TYPO3 Core Contribution how to properly work on a patch (change it) or ask in the #typo3-cms-coredev slack channel for help)
  5. Stefan Bürk commented on patch set 1 CR -2 08/15/22, 07:02

    Reply

    Done

    Reply

    Done

    ApcuBackend.php:18

    We do not add use clauses for top top level classes in the core.
  6. Stefan Bürk abandoned the change 08/15/22, 07:02

    Missed to amend to the original patch.