Review 11.5 Merged

75447[BUGFIX] Do not hide ContentObjectRenderer on form rendering

Oliver Hader CR +2 V +2 Easy +16 −1 updated 08/15/22, 07:57

Commit message

With #93887 (respectively #92406), a more convenient rendering
mechanism for forms was introduced. A new FormRequestHandler
centralized all the logic from the <formvh:render> view helper
to allow smoother form handling. However, the new implementation
used to hide the current ContentObjectRenderer implementation
and instead always fetched a new instance with
GeneralUtility::makeInstance().

This no longer allows to determine the current content object
rendering context from e.g. form finishers. Since the current
implementation can be retrieved by the ConfigurationManager,
it is now used in the <formvh:render> view helper, falling
back to a new ContentObjectRenderer instance in case the
ConfigurationManager does not actually provide an instance
of ContentObjectRenderer.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
  • Verified V +2 Done
    • Oliver Hader +2
    • core-ci +1 CI

Issues 3

Files 1

Review log 45

  1. Oliver Hader uploaded patch set 1 08/15/22, 07:46

  2. core-ci voted on patch set 1 V +1 08/15/22, 07:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30177

  3. Oliver Hader voted on patch set 1 V +1 CR +1 08/15/22, 07:54

  4. Oliver Hader voted on patch set 1 V +2 CR +2 08/15/22, 07:57

  5. Oliver Hader merged patch set 2 08/15/22, 07:57