Review 11.5 Merged

75454Revert "[BUGFIX] Abort commit if commit message does not fulfill all requirements"

Christian Kuhn CR +2 V +2 Easy +0 −1 updated 08/12/22, 18:32

Commit message

This reverts commit b2bb59943e3b57aad3aee8d885cb6ae64f8cb69c.

Reason for revert:
The commit-msg hook now tends to throw away the message.
Fully loosing a commit message is worse than a funny
exit code. We revert for now and eventually come up
with a different solution later.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Anja Leichsenring +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Christian Kuhn uploaded patch set 1 08/12/22, 18:08

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 08/12/22, 18:09

  3. Anja Leichsenring updated the commit message in patch set 2 08/12/22, 18:19

  4. Stefan Bürk voted on patch set 2 V +1 CR +1 08/12/22, 18:19

  5. Anja Leichsenring voted on patch set 2 V +1 CR +1 08/12/22, 18:19

  6. Simon Schaufelberger voted on patch set 2 V +1 CR +1 08/12/22, 18:28

  7. core-ci voted on patch set 2 V +1 08/12/22, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30116

  8. core-ci voted on patch set 1 V +1 08/12/22, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30114

  9. Stefan Bürk voted on patch set 2 V +2 CR +2 08/12/22, 18:32

  10. Stefan Bürk merged patch set 3 08/12/22, 18:32