Review main Merged

75474[BUGFIX] Fix warning on array key updateReferenceIndex

Tomek Woldański CR +2 V +2 Easy +1 −1 updated 08/17/22, 09:16

Commit message

Patch fixes warning on PHP 8.1 in extbase Backend class.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1012

  1. Tomek Woldański uploaded patch set 1 08/16/22, 08:34

  2. core-ci voted on patch set 1 V +1 08/16/22, 08:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30189

  3. Oliver Klee voted on patch set 1 CR +1 08/16/22, 09:17

  4. Oliver Klee commented on patch set 1 08/16/22, 09:18

    Nitpick: Generally, please start the subject line of the commit message with a capital letter.
  5. Oliver Klee updated the commit message in patch set 2 08/16/22, 09:18

  6. Oliver Klee commented on patch set 2 CR +1 08/16/22, 09:18

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 08/16/22, 09:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30194

  8. Tomek Woldański commented on patch set 2 08/16/22, 09:35

    Reply

    My bad. Sorry & thank you for quick fix!
  9. Christian Kuhn voted on patch set 2 V +1 CR +1 08/17/22, 07:28

  10. Benni Mack voted on patch set 2 V +1 CR +1 08/17/22, 09:13

  11. Christian Kuhn voted on patch set 2 V +2 CR +2 08/17/22, 09:16

  12. Christian Kuhn merged patch set 3 08/17/22, 09:16