Review main Merged

75477[BUGFIX] Avoid open_basedir errors when referencing absolute URLs

Benni Mack CR +2 V +2 Easy +6 −1 updated 08/16/22, 13:58

Commit message

Backend modules which use absolute paths (which do not
exist) should not raise an exception / error when
using versionNumberInFilename checks.

This happens e.g. with EXT:solr backend modules
since #97939 was fixed.

In the long-term extensions should define proper
paths, so they also work in TYPO3 installations within
a subfolder but for the time being,
this change helps to solve the problem.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Lina Wolf +1
    • David Steeb +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Lina Wolf +1
    • David Steeb +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 3

Files 1

Review log 79

  1. Benni Mack uploaded patch set 1 08/16/22, 13:02

  2. Benni Mack updated the commit message in patch set 2 08/16/22, 13:02

  3. Lina Wolf commented on patch set 2 V +1 CR +1 08/16/22, 13:08

    Works well for my test case with the solr backend modules in TYPO3 v11.5.14, code looks good to me but someone else should also review
  4. core-ci voted on patch set 1 V +1 08/16/22, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30199

  5. core-ci voted on patch set 2 V +1 08/16/22, 13:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30200

  6. Simon Schaufelberger voted on patch set 2 V +1 CR +1 08/16/22, 13:55

  7. David Steeb voted on patch set 2 V +1 CR +1 08/16/22, 13:57

  8. Benni Mack voted on patch set 2 V +2 CR +2 08/16/22, 13:58

  9. Benni Mack merged patch set 3 08/16/22, 13:58