75480[!!!][FEATURE] Integrate CKEditor5 as new RTE
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Georg Ringer +1
- core-ci +1 CI
Issues 1
Files 40
- Build/Sources/JavaScript/rte_ckeditor/contrib/ckeditor5-bundle.jsnew+77 −0
- Build/Sources/TypeScript/rte_ckeditor/observer/double-click-observer.tsnew+9 −0
- Build/Sources/TypeScript/rte_ckeditor/plugin/soft-hyphen.tsnew+30 −0
- Build/Sources/TypeScript/rte_ckeditor/plugin/typo3-link.tsnew+389 −0
- Build/Sources/TypeScript/rte_ckeditor/ckeditor-loader.tsdeleted+0 −20
- Build/Sources/TypeScript/rte_ckeditor/ckeditor5.tsnew+185 −0
- Build/Sources/TypeScript/rte_ckeditor/form-engine-initializer.tsdeleted+0 −76
- Build/Sources/TypeScript/rte_ckeditor/rte-link-browser.ts+46 −37
- Build/types/TYPO3/index.d.ts+23 −0
- Build/ckeditor5.rollup.config.jsnew+36 −0
- Build/Gruntfile.js+3 −35
- Build/package-lock.json+2718 −486
- Build/package.json+56 −3
- Build/tsconfig.json+0 −1
- typo3/sysext/core/Classes/Configuration/CKEditor5Migrator.phpnew+277 −0
- typo3/sysext/core/Classes/Configuration/Richtext.php+7 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-96874-CKEditor-relatedPluginsAndConfiguration.rstnew+97 −0
- typo3/sysext/core/Documentation/Changelog/12.0/Feature-96874-CKEditor5.rstnew+188 −0
- typo3/sysext/core/composer.json+1 −0
- typo3/sysext/rte_ckeditor/Classes/Controller/ResourceController.phpnew+79 −0
Show 20 more files
- typo3/sysext/rte_ckeditor/Classes/Form/Element/RichTextElement.php4+53 −34
- typo3/sysext/rte_ckeditor/Configuration/Backend/Routes.php+10 −2
- typo3/sysext/rte_ckeditor/Configuration/RTE/Editor/Base.yaml+5 −25
- typo3/sysext/rte_ckeditor/Configuration/RTE/Editor/Plugins.yaml+19 −9
- typo3/sysext/rte_ckeditor/Configuration/RTE/Default.yaml+57 −29
- typo3/sysext/rte_ckeditor/Configuration/RTE/Full.yaml+62 −47
- typo3/sysext/rte_ckeditor/Configuration/RTE/Minimal.yaml+8 −9
- typo3/sysext/rte_ckeditor/Configuration/RTE/Processing.yaml+2 −1
- typo3/sysext/rte_ckeditor/Configuration/JavaScriptModules.php+1 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Contrib/ckeditor5-bundle.jsnew+105354 −0
- typo3/sysext/rte_ckeditor/Resources/Public/Css/contents.css+12 −4
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/observer/double-click-observer.jsnew+13 −0
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/plugin/soft-hyphen.jsnew+13 −0
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/plugin/timestamp.jsnew+13 −0
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/plugin/typo3-link.jsnew+13 −0
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/ckeditor5.jsnew+22 −0
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/form-engine-initializer.jsdeleted+0 −13
- typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/rte-link-browser.js+1 −1
- composer.json+1 −0
- composer.lock+81 −1
Review log 64109
Show 4784 earlier messages
-
Benni Mack uploaded patch set 1 08/17/22, 10:55
-
core-ci voted on patch set 1 V +1 08/17/22, 11:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30226
-
Oliver Hader uploaded patch set 2 08/17/22, 11:40
-
core-ci voted on patch set 2 V -1 08/17/22, 11:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30230
-
Benjamin Franzke uploaded patch set 3 08/23/22, 20:44
-
core-ci voted on patch set 3 V +1 08/23/22, 20:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30392
-
Oliver Hader uploaded patch set 4 08/26/22, 09:41
-
core-ci voted on patch set 4 V -1 08/26/22, 09:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30458
-
Oliver Hader uploaded patch set 5 08/26/22, 18:09
-
core-ci voted on patch set 5 V -1 08/26/22, 18:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30472
-
Benjamin Franzke uploaded patch set 6 08/29/22, 06:39
-
Benjamin Franzke commented on patch set 6 08/29/22, 06:39
Not sure whether it is "better", but for bootstrap.js (which we bundled via an entry-point script as well ) we used: Build/Sources/JavaScript/core/Resources/Public/JavaScript/Contrib/bootstrap.js (Although I'd drop Resources/Public/JavaScript from the path nowadays). So maybe: Build/Sources/JavaScript/rte_ckeditor/contrib/ckeditor5-bundle.js Did so in patchset 6.yea, we should probably use something like @typo3/ckeditor5-bundle instead, as @ckeditor/ckeditor5 isn't available as a npm package all, and it contains a custom composition of ckeditor5 packages, so it's rather a @typo3/... thing. Then a custom declaration doesn't feel so wrong (and is fine) IMO. Did so in patchset 6, hope that's ok. -
core-ci voted on patch set 6 V +1 08/29/22, 06:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30515
-
Oliver Hader commented on patch set 6 08/31/22, 20:05
Reply
> Did so in patchset 6, hope that's ok. Any change/improvement is totally fine, thx! I felt kind of lost with the combination of Grunt, Rollup (or Webpack) and the CKEditor5 dependencies... -
Oliver Hader uploaded patch set 7 09/07/22, 17:45
-
core-ci voted on patch set 7 V +1 09/07/22, 17:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30776
-
Oliver Hader uploaded patch set 8 09/07/22, 18:29
-
core-ci voted on patch set 8 V +1 09/07/22, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30778
-
Tyrell king commented on patch set 8 09/07/22, 18:47
test -
Tyrell king commented on patch set 8 09/07/22, 18:50
<a onmouseover="alert(1)">xyz link</a> -
Oliver Hader commented on patch set 8 09/07/22, 18:51
Reply
https://typo3.org/community/teams/security/bug-bounty-program → please report potential security issues to mailto:security@typo3.org -
Benjamin Franzke commented on patch set 8 09/07/22, 18:55
Reply
I think this was a penetration test against this gerrit instance, not a security report. -
Benni Mack wrote 09/07/22, 19:45
Removed cc Tyrell king. -
Oliver Hader uploaded patch set 9 09/08/22, 10:56
-
core-ci voted on patch set 9 V -1 09/08/22, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30804
-
Oliver Hader uploaded patch set 10 09/21/22, 07:23
-
core-ci voted on patch set 10 V -1 09/21/22, 07:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31338
-
Oliver Hader uploaded patch set 11 09/21/22, 13:06
-
core-ci voted on patch set 11 V -1 09/21/22, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31368
-
Oliver Hader uploaded patch set 12 09/21/22, 15:14
-
core-ci voted on patch set 12 V -1 09/21/22, 15:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31385
-
Oliver Hader uploaded patch set 13 09/22/22, 14:43
-
core-ci voted on patch set 13 V -1 09/22/22, 14:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31456
-
Oliver Hader uploaded patch set 14 09/23/22, 10:51
-
core-ci voted on patch set 14 V -1 09/23/22, 10:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31476
-
Oliver Hader uploaded patch set 15 09/23/22, 15:40
-
core-ci voted on patch set 15 V -1 09/23/22, 15:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31486
-
Oliver Hader uploaded patch set 16 09/28/22, 16:48
-
core-ci voted on patch set 16 V -1 09/28/22, 16:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31670
-
Benni Mack uploaded patch set 17 09/28/22, 21:23
-
core-ci voted on patch set 17 V -1 09/28/22, 21:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31673
-
Benni Mack uploaded patch set 18 09/28/22, 21:59
-
core-ci voted on patch set 18 V -1 09/28/22, 22:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31674
-
Oliver Hader uploaded patch set 19 09/28/22, 22:13
-
core-ci voted on patch set 19 V -1 09/28/22, 22:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31675
-
Oliver Hader commented on patch set 19 09/28/22, 22:36
bootstrap.js:1Unrelated... probably due to newer rollup or whatever version -
Benni Mack uploaded patch set 20 09/28/22, 22:51
-
Oliver Hader uploaded patch set 21 09/28/22, 22:56
-
core-ci voted on patch set 20 V -1 09/28/22, 22:59 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31676
-
core-ci voted on patch set 21 V -1 09/28/22, 23:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31677
-
Benni Mack uploaded patch set 22 09/28/22, 23:09
-
Benni Mack uploaded patch set 23 09/28/22, 23:15
-
core-ci voted on patch set 22 V -1 09/28/22, 23:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31678
-
Benni Mack updated the commit message in patch set 24 09/28/22, 23:19
-
Benni Mack uploaded patch set 25 09/28/22, 23:20
-
core-ci voted on patch set 23 V -1 09/28/22, 23:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31679
-
core-ci voted on patch set 24 V -1 09/28/22, 23:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31680
-
core-ci voted on patch set 25 V -1 09/28/22, 23:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31681
-
Oliver Hader uploaded patch set 26 09/29/22, 07:39
-
core-ci voted on patch set 26 V -1 09/29/22, 07:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31689
-
Oliver Hader uploaded patch set 27 09/29/22, 11:25
-
core-ci voted on patch set 27 V -1 09/29/22, 11:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31700
-
Oliver Hader uploaded patch set 28 09/29/22, 15:02
-
core-ci voted on patch set 28 V -1 09/29/22, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31712
-
Oliver Hader uploaded patch set 29 09/29/22, 15:21
-
core-ci voted on patch set 29 V -1 09/29/22, 15:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31713
-
Benni Mack uploaded patch set 30 09/29/22, 22:46
-
core-ci voted on patch set 30 V -1 09/29/22, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31720
-
Benni Mack uploaded patch set 31 09/29/22, 22:57
-
Benni Mack uploaded patch set 32 09/29/22, 22:58
-
core-ci voted on patch set 32 V -1 09/29/22, 23:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31723
-
core-ci voted on patch set 31 V -1 09/29/22, 23:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31722
-
Oliver Hader uploaded patch set 33 09/30/22, 12:00
-
core-ci voted on patch set 33 V +1 09/30/22, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31744
-
Oliver Hader uploaded patch set 34 09/30/22, 12:08
-
core-ci voted on patch set 34 V +1 09/30/22, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31745
-
Benni Mack uploaded patch set 35 09/30/22, 12:15
-
core-ci voted on patch set 35 V +1 09/30/22, 12:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31746
-
Benni Mack uploaded patch set 36 09/30/22, 12:52
-
Benni Mack commented on patch set 36 09/30/22, 12:54
bootstrap.js:1ReplyDone -
core-ci voted on patch set 36 V +1 09/30/22, 13:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31750
-
Oliver Hader uploaded patch set 37 09/30/22, 13:19
-
core-ci voted on patch set 37 V +1 09/30/22, 13:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31756
-
Oliver Hader uploaded patch set 38 09/30/22, 14:59
-
core-ci voted on patch set 38 V +1 09/30/22, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31762
-
Benni Mack uploaded patch set 39 09/30/22, 15:49
-
core-ci voted on patch set 39 V +1 09/30/22, 15:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31764
-
Oliver Hader uploaded patch set 40 09/30/22, 20:36
-
core-ci voted on patch set 40 V +1 09/30/22, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31770
-
Benni Mack voted on patch set 40 V +1 CR +1 09/30/22, 21:24
-
Oliver Hader uploaded patch set 41 10/01/22, 07:32
-
core-ci voted on patch set 41 V +1 10/01/22, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31801
-
Benjamin Franzke uploaded patch set 42 10/01/22, 08:18
-
core-ci voted on patch set 42 V +1 10/01/22, 08:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31803
-
Benni Mack commented on patch set 42 V +1 CR +1 10/01/22, 08:52
Still flaky but I think we should integrate it rather sooner than just before the LTS release ;) -
Benjamin Franzke commented on patch set 42 10/01/22, 10:27
RichTextElement.php:137Hm, so this field-dependent prefix will result in a cached css file to be created for every content element that is added. Do we really need to take into account the `$fieldId` in the cssPrefix? Is that because RTE configuration may be configured per page/table/whatever (i don't know all the possibilities to be honest). Would really be valueable when ckeditor could be rendered into shadowdom. -
Oliver Hader commented on patch set 42 10/01/22, 11:52
RichTextElement.php:137ReplyShadowDOM and cache-identifier would be a future optimization (actually the partition is just the `styleScr`). -
Benjamin Franzke commented on patch set 42 10/01/22, 14:08
RichTextElement.php:137Reply> actually the partition is just the `styleScr You mean like "should be" (as future optimization)? Because currently it is really both, $cssPrefix and $styleSrc: > $styleSrcHash = sha1(json_encode([$cssPrefix, $styleSrcContent])); https://review.typo3.org/c/Packages/TYPO3.CMS/+/75480/42/typo3/sysext/rte_ckeditor/Classes/Controller/ResourceController.php#54 -
Benni Mack uploaded patch set 43 10/01/22, 15:08
-
core-ci voted on patch set 43 V +1 10/01/22, 15:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31830
-
Georg Ringer voted on patch set 43 V +1 CR +1 10/01/22, 18:48
-
Benjamin Franzke uploaded patch set 44 10/01/22, 18:51
-
Benjamin Franzke commented on patch set 44 10/01/22, 18:59
Note: moved the requirejs-cleanup in coordination with benni into a separate TASK which can be merged in parallel (before or after this one, doesn't matter): https://review.typo3.org/c/Packages/TYPO3.CMS/+/75936RichTextElement.php:137ReplyOk, anyway, let's fix that later on. -
core-ci voted on patch set 44 V -1 10/01/22, 19:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31841
-
Benjamin Franzke commented on patch set 44 V +1 CR +1 10/01/22, 19:09
Voting positive now to merge this asap, albeit there is still quite some stuff to be done: Especially annoying is the behaviour when writing a lot of content: * the ballooning-toolbar sticks to the docheader when scrolling back up * missing max-height -
core-ci voted on patch set 44 V +1 10/01/22, 19:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31841
-
Georg Ringer voted on patch set 44 V +1 CR +1 10/01/22, 20:01
-
Benjamin Franzke commented on patch set 44 V +2 CR +2 10/01/22, 20:16
Merging now, decision to merge was basically already taken in https://review.typo3.org/c/Packages/TYPO3.CMS/+/75480/44#message-f7c2342f6bfa4bcffc153c917fd819fdf2646479 and this is starting to block other patches. -
Benjamin Franzke merged patch set 45 10/01/22, 20:17