75482[FEATURE] Reactions - Incoming WebHooks for TYPO3
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Benni Mack +2
- Oli Bartsch +1
- Frank Nägler +1
- Andreas Kienast +1
- Susi Moog +1
- Andreas Wolf +1
-
Verified V +2 Done
- Oliver Hader +2
- Benni Mack +2
- Oli Bartsch +1
- Frank Nägler +1
- Andreas Kienast +1
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 44
- typo3/sysext/core/Documentation/Changelog/12.1/Feature-98373-ReactionIncomingWebHooksforTYPO3.rstnew+66 −0
- typo3/sysext/reactions/Classes/Authentication/ReactionUserAuthentication.phpnew+89 −0
- typo3/sysext/reactions/Classes/Controller/ManagementController.php2new+111 −0
- typo3/sysext/reactions/Classes/Exception/ReactionNotFoundException.phpnew+22 −0
- typo3/sysext/reactions/Classes/Form/Element/FieldMapElement.phpnew+100 −0
- typo3/sysext/reactions/Classes/Form/Element/UuidElement.php2new+80 −0
- typo3/sysext/reactions/Classes/Form/ReactionItemsProcFunc.php2new+52 −0
- typo3/sysext/reactions/Classes/Hooks/DataHandlerHook.php10new+47 −0
- typo3/sysext/reactions/Classes/Http/Middleware/ReactionResolver.php2new+108 −0
- typo3/sysext/reactions/Classes/Http/ReactionHandler.php11new+91 −0
- typo3/sysext/reactions/Classes/Model/ReactionInstruction.phpnew+68 −0
- typo3/sysext/reactions/Classes/Pagination/DemandedArrayPaginator.phpnew+66 −0
- typo3/sysext/reactions/Classes/Reaction/CreateRecordReaction.php3new+133 −0
- typo3/sysext/reactions/Classes/Reaction/ReactionInterface.php3new+45 −0
- typo3/sysext/reactions/Classes/Repository/ReactionDemand.php2new+140 −0
- typo3/sysext/reactions/Classes/Repository/ReactionRepository.phpnew+153 −0
- typo3/sysext/reactions/Classes/ReactionRegistry.php2new+49 −0
- typo3/sysext/reactions/Configuration/Backend/Modules.php3new+23 −0
- typo3/sysext/reactions/Configuration/Backend/Routes.phpnew+13 −0
- typo3/sysext/reactions/Configuration/TCA/Overrides/sys_reaction_create_record.phpnew+76 −0
Show 24 more files
- typo3/sysext/reactions/Configuration/TCA/sys_reaction.phpnew+149 −0
- typo3/sysext/reactions/Configuration/Icons.phpnew+14 −0
- typo3/sysext/reactions/Configuration/RequestMiddlewares.phpnew+18 −0
- typo3/sysext/reactions/Configuration/Services.yamlnew+21 −0
- typo3/sysext/reactions/Resources/Private/Language/locallang_db.xlf2new+94 −0
- typo3/sysext/reactions/Resources/Private/Language/locallang_module_reactions.xlf2new+77 −0
- typo3/sysext/reactions/Resources/Private/Partials/Pagination.html3new+96 −0
- typo3/sysext/reactions/Resources/Private/Templates/Management/Overview.htmlnew+195 −0
- typo3/sysext/reactions/Resources/Public/Icons/Extension.svgnew+1 −0
- typo3/sysext/reactions/Resources/Public/Icons/mimetypes-x-sys_reaction.svgnew+1 −0
- typo3/sysext/reactions/Tests/Functional/Fixtures/ReactionsRepositoryTest_pages.csvnew+3 −0
- typo3/sysext/reactions/Tests/Functional/Fixtures/ReactionsRepositoryTest_reactions.csvnew+4 −0
- typo3/sysext/reactions/Tests/Functional/Reaction/CreateRecordReactionTest.phpnew+279 −0
- typo3/sysext/reactions/Tests/Functional/Repository/ReactionsRepositoryTest.phpnew+86 −0
- typo3/sysext/reactions/Tests/Functional/ReactionRegistryTest.phpnew+70 −0
- typo3/sysext/reactions/.gitattributesnew+2 −0
- typo3/sysext/reactions/composer.jsonnew+41 −0
- typo3/sysext/reactions/ext_emconf.phpnew+19 −0
- typo3/sysext/reactions/ext_localconf.phpnew+24 −0
- typo3/sysext/reactions/ext_tables.sql2new+16 −0
- typo3/sysext/reactions/LICENSE.txtnew+339 −0
- typo3/sysext/reactions/README.rst2new+12 −0
- composer.json2+4 −0
- composer.lock2+161 −5
Review log 135189
Show 114164 earlier messages
-
Frank Nägler uploaded patch set 1 08/17/22, 15:32
-
Frank Nägler uploaded patch set 2 08/17/22, 19:34
-
Frank Nägler uploaded patch set 3 08/17/22, 22:02
-
Frank Nägler uploaded patch set 4 08/18/22, 09:06
-
Andreas Kienast commented on patch set 4 08/18/22, 12:54
ManagementController.php:33Copy/pasta commentREADME.rst:2No no no no no ;) -
Frank Nägler commented on patch set 4 08/18/22, 12:58
icons.json:3969Reply> Please do not modify this manually must be changed laterManagementController.php:33ReplyDoneREADME.rst:2ReplyDone -
Andreas Kienast commented on patch set 4 08/18/22, 13:00
ReactionHandler.php:73I think this needs more conceptual work. I just checked Github, there I cannot configure the header name used to transmit the secret. Perhaps, such cases need a dedicated middleware to "translate" the headers. -
Frank Nägler commented on patch set 4 08/18/22, 13:17
ReactionHandler.php:73ReplyCorrect, this must be changed to get a parameter. The header idea is not useful in this context. Besides that, the whole auth part is something we have to discuss. -
Andreas Kienast commented on patch set 4 08/19/22, 05:12
composer.lock:8514Please upgrade to Composer 2.3 -
Frank Nägler uploaded patch set 5 08/22/22, 12:05
-
Frank Nägler uploaded patch set 6 08/22/22, 12:54
-
Frank Nägler uploaded patch set 7 08/22/22, 18:55
-
Frank Nägler uploaded patch set 8 08/23/22, 08:09
-
Oliver Hader commented on patch set 8 08/26/22, 07:19
In general, I think the overall concept of "reactions" needs to be streamlined. The current behavior mimics the behavior of a web API, allowing to process data with a dedicated action (C*UD currently via CreateRecordReaction etc. - but no ReadRecordReaction). A reduced permission set is organized in new sys_reaction table. I currently these two directions: 1) Maybe we want to have a web API (REST? API) with generic authentication and generic permissions for any resource → that would not be related to the web-hook topic, but a general public API. Instead of a "user" the could be a "role" to grant particular permissions (CRUD, fields, TCA-types, modifications on child items, etc.). 2) Maybe we want to re-introduce sys_action, which allows to declare "completed" actions or adjust data by defined variables. A "sys_reaction" would then expose a particular "sys_action" to the web interface, giving it a name/identifier and some auth mechanism.ReactionHandler.php:55In case a website is vulnerable to SQL injection (e.g. through 3rd party code), these "secret keys" can directly be fetched from database and used to invoke a "reaction". Usually these "secrets" (or tokens) are only shown once during creation, and are stored hashed/salted in the database. Currently "secretKey" serves as password and as identifier - probably these two aspects should be separated and used explicitly. -
Oliver Hader commented on patch set 8 08/26/22, 07:25
ReactionHandler.php:55ReplyAddition: I also would be possible to use asymmetric encryption on the actual payload - the secret key is only shown once to the client, when creating a new item in the backend, but the server only stores the public key. Each incoming request then either could to be encrypted, or at least needs to be signed - e.g. using https://tweetnacl.js.org/#/sign -
Oli Bartsch commented on patch set 8 09/02/22, 13:00
kendDataHandlerHook.php:45We might want to use a new TCA type for thisDataHandlerHook.php:54We might want to use a new TCA type for thisReactionHandler.php:29backendReactionHandler.php:75This is currently triggered on every POST request.ReactionService.php:57We should just use the service from $registeredReactions here. Something link `$this->getReactionByIdentifier($reactionRecord['reaction'])`. public function getReactionByIdentifier(string $identifier): ?ReactionInterface { /** @var ReactionInterface $reaction */ foreach ($this->registeredReactions as $reaction) { if ($reaction->getIdentifier() === $identifier) { return $reaction; } } return null; } -
Oli Bartsch commented on patch set 8 09/02/22, 15:56
ReactionHandler.php:73What do you think of using dedicated endpoints (speaking paths) instead of a random secret.ReactionInterface.php:26Current implementation (ReactionService) instances the reaction always based on the database value. Therefore, it should be mandatory to use the FQN, right?RecordReactionTrait.php:43Not important in current state but please lets use the PRS-17 factories here in the end.RecordReactionTrait.php:53What do you think of introducing another special user "_reactions_", similar to the "_cli_" user.ReactionService.php:29ReactionRegistry might be a better term, since this holds the registered reactions and also allows to access / use them. We also used this therm in core for latest - similar - introductions.AllowedTablesItemsProcFunc.php:20We might want to use existing `TYPO3\CMS\Core\Hooks\TcaItemsProcessorFunctions->populateAvailableTables()` here? - We might need to adjust it to allow checking of additional "filter fields".Modules.php:20Not used in the corresponding controllerPagination.html:39We might want to make use of the global event handler here instead. See usage e.g. in https://github.com/TYPO3/typo3/blob/main/typo3/sysext/beuser/Resources/Private/Partials/SimplePagination.html#L38 -
Oli Bartsch commented on patch set 8 09/02/22, 15:57
Reply
Oops.. not intended -
Frank Nägler commented on patch set 8 09/05/22, 10:55
Thank you all for the feedback. I will work on a new patchset the next days and will try to take care of all your feedback,Reply
Yes, the first three implementations are a kind of CRUD implementation. I will remove that. The idea is more the implementation I made in the VisualCreateRecordReaction. Click records together that can be enriched with data from the payload.DataHandlerHook.php:45ReplyAckDataHandlerHook.php:54ReplyAckReactionHandler.php:29ReplyAckReactionHandler.php:55ReplyI agree with the first part (show token only once, stored hashed). Regarding the second part, this must be optional because, e.g., GitHub will not sign or encrypt a request. The idea is to use any external request/payload to do something with that. Example: A new release is tagged on GitHub; create a tt_content record with a release announcement.ReactionHandler.php:73Replynot sure, do you have a concrete example?ReactionHandler.php:75ReplyAckReactionInterface.php:26ReplyAckRecordReactionTrait.php:43ReplyAckRecordReactionTrait.php:53ReplyI agree; that is also the reason for the @TODO marker. This fake admin is to quickly test the PoC, which can't be the final solution and is also maybe a security risk.ReactionService.php:29ReplyAckReactionService.php:57ReplyAckModules.php:20ReplyAck -
Frank Nägler uploaded patch set 9 09/06/22, 11:52
-
Frank Nägler commented on patch set 9 09/06/22, 11:54
DataHandlerHook.php:45ReplyDoneReactionHandler.php:29ReplyDoneReactionHandler.php:75ReplyDoneReactionInterface.php:26ReplyDoneRecordReactionTrait.php:43ReplyDoneReactionService.php:29ReplyDoneReactionService.php:57ReplyDoneAllowedTablesItemsProcFunc.php:20ReplyThis is something we should talk about. Unfortunately, I am not sure we have the same understanding. I will ping you in the next few days.Modules.php:20ReplyDonePagination.html:39Replyworks only with extbase controllers, but this is no extbase. -
Frank Nägler commented on patch set 9 09/06/22, 11:57
ReactionHandler.php:73ReplyDone -
Frank Nägler uploaded patch set 10 09/14/22, 13:42
-
Frank Nägler commented on patch set 10 09/14/22, 13:43
composer.lock:8514ReplyDone -
Frank Nägler commented on patch set 10 09/15/22, 12:50
DataHandlerHook.php:54ReplyDone -
Frank Nägler uploaded patch set 11 09/15/22, 12:50
-
Frank Nägler uploaded patch set 12 09/15/22, 12:56
-
Frank Nägler uploaded patch set 13 09/16/22, 09:26
-
Frank Nägler commented on patch set 12 09/16/22, 09:26
AllowedTablesItemsProcFunc.php:20ReplyDone -
Frank Nägler commented on patch set 13 09/19/22, 08:12
Reply
Doneicons.json:3969ReplyDoneReactionHandler.php:55ReplyDoneReactionHandler.php:73ReplyDone -
Frank Nägler uploaded patch set 14 09/19/22, 08:13
-
Frank Nägler uploaded patch set 15 09/19/22, 12:10
-
Frank Nägler commented on patch set 15 09/19/22, 12:10
RecordReactionTrait.php:53ReplyDonePagination.html:39ReplyDone -
Frank Nägler wrote 09/19/22, 12:10
Unset private -
core-ci voted on patch set 15 V -1 09/19/22, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31266
-
Frank Nägler uploaded patch set 16 09/19/22, 12:42
-
core-ci voted on patch set 16 V -1 09/19/22, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31269
-
Frank Nägler uploaded patch set 17 09/19/22, 13:22
-
core-ci voted on patch set 17 V -1 09/19/22, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31272
-
Guido Schmechel commented on patch set 17 09/19/22, 21:20
Interesting topic, I am curious to see where the journey goes. So first of all, thank you for the great implementation and the (time) investment. I played around a bit, created a redirect, and here is my little feedback: - UX: I would like to be able to copy the secret with a button click ;-) - UX: I would include the URL in the edit form and display it. (One click less per action) - UX: It would also be nice if we could see an example JSON based on the allowed fields. You know: Users are lazy. - Code: I had a few PHP warnings with $tca['columns'] - Code: The reading of the fields should respect readOnly https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/ColumnsConfig/CommonProperties/ReadOnly.html - Code: The selection of fields is quite static in FieldMapElement. I would suggest adding a PSR 14 event here - Code: TcaItemsProcessorFunctions.php should also respect the TCA readOnly option https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/Ctrl/Properties/ReadOnly.html But important: In the end, a redirect was successfully created ;-) -
Frank Nägler uploaded patch set 18 09/20/22, 10:22
-
Frank Nägler commented on patch set 17 09/20/22, 10:30
Reply
Thank you for your feedback. > - UX: I would like to be able to copy the secret with a button click ;-) This should be done in its own patch because this is a new FormElementWizard for the FormEngine, but it is a nice idea. > - UX: I would include the URL in the edit form and display it. (One click less per action) Good idea. I already added it to the edit form. > - UX: It would also be nice if we could see an example JSON based on the allowed fields. You know: Users are lazy. As discussed in private chat, this makes no sense because any payload is different and would confuse the user. > - Code: I had a few PHP warnings with $tca['columns'] Still open; I will check that next. > - Code: The reading of the fields should respect readOnly https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/ColumnsConfig/CommonProperties/ReadOnly.html > - Code: The selection of fields is quite static in FieldMapElement. I would suggest adding a PSR 14 event here > - Code: TcaItemsProcessorFunctions.php should also respect the TCA readOnly option https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/Ctrl/Properties/ReadOnly.html The editing interface needs more love, and I will talk about that topic with some UX/UI people. Only text input fields are supported at the moment. I added a TODO marker to make that more precise that this part is still open for the final patch. > But essential: In the end, a redirect was successfully created ;-) Yeah, that is nice 😊 -
core-ci voted on patch set 18 V +1 09/20/22, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31307
-
Frank Nägler uploaded patch set 19 09/20/22, 11:29
-
core-ci voted on patch set 19 V +1 09/20/22, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31317
-
Simon Schaufelberger commented on patch set 19 09/20/22, 20:47
While Benni announced this cool new feature, I know that the Laravel community has a package for that already. Did you have a look at this? https://github.com/spatie/laravel-webhook-server https://github.com/spatie/laravel-webhook-client -
Simon Schaufelberger commented on patch set 19 09/20/22, 21:06
Fields.html:4lang attribute can be removed, or? -
Frank Nägler uploaded patch set 20 09/21/22, 11:51
-
Frank Nägler commented on patch set 20 09/21/22, 11:52
Reply
Thanks for your feedback, I know about the Laraval packages and checked other packages too. Most of the time, the problem with other packages is the integration in TYPO3 (bootstrap process, session, etc.),Fields.html:4ReplyAck -
core-ci voted on patch set 20 V +1 09/21/22, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31354
-
Simon Schaufelberger commented on patch set 20 09/21/22, 12:24
Reply
Ack -
Simon Schaufelberger uploaded patch set 21 09/21/22, 14:43
-
Simon Schaufelberger uploaded patch set 22 09/21/22, 14:44
-
core-ci voted on patch set 21 V +1 09/21/22, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31378
-
Simon Schaufelberger uploaded patch set 23 09/21/22, 14:56
-
core-ci voted on patch set 22 V +1 09/21/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31379
-
Simon Schaufelberger commented on patch set 23 09/21/22, 15:01
ext_tables.sql:8since table is a reserved keyword, I checked what FAL and sys_refinxex is using and there it's "tablenames"/"tablename". Should we use "table_name"/"tablename" here instead? -
Simon Schaufelberger commented on patch set 23 09/21/22, 15:03
I improved the fluid templates a bit, minified the svgs and some other minor things. -
core-ci voted on patch set 23 V +1 09/21/22, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31381
-
Simon Schaufelberger commented on patch set 23 V -1 09/21/22, 15:18
InputSecretElement.php:60I've played with it and it crashes here with undefined array key "columns" when creating a new record. -
Frank Nägler commented on patch set 23 09/28/22, 11:39
InputSecretElement.php:60ReplyDoneext_tables.sql:8ReplyDone -
Frank Nägler uploaded patch set 24 09/28/22, 11:40
-
core-ci voted on patch set 24 V -1 09/28/22, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31650
-
core-ci commented on patch set 24 09/28/22, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31650
-
Frank Nägler uploaded patch set 25 09/28/22, 13:05
-
core-ci voted on patch set 25 V +1 09/28/22, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31654
-
Benni Mack commented on patch set 25 10/04/22, 08:17
How about moving the Secret Element as a common TCA type as a pre-patch / feature? -
Benni Mack uploaded patch set 26 10/04/22, 19:59
-
core-ci voted on patch set 26 V +1 10/04/22, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32012
-
Frank Nägler commented on patch set 26 CR -1 10/06/22, 11:21
Reply
yes, will do that as a pre-patch and then update this patch -
Frank Nägler uploaded patch set 27 10/07/22, 14:31
-
core-ci voted on patch set 27 V -1 10/07/22, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32074
-
Frank Nägler rebased onto patch set 28 10/07/22, 16:39
-
core-ci voted on patch set 28 V +1 10/07/22, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32078
-
Frank Nägler uploaded patch set 29 10/07/22, 16:51
-
Frank Nägler uploaded patch set 30 10/07/22, 16:54
-
core-ci voted on patch set 29 V +1 10/07/22, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32079
-
core-ci voted on patch set 30 V +1 10/07/22, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32080
-
Frank Nägler rebased onto patch set 31 10/18/22, 07:33
-
core-ci voted on patch set 31 V +1 10/18/22, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32415
-
Oli Bartsch uploaded patch set 32 11/08/22, 22:08
-
core-ci voted on patch set 32 V +1 11/08/22, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33362
-
Oli Bartsch uploaded patch set 33 11/10/22, 13:07
-
Benni Mack commented on patch set 33 11/10/22, 13:08
composer.json:284ordering is wrong here. (not alphabetical) -
core-ci voted on patch set 33 V +1 11/10/22, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33492
-
Oli Bartsch uploaded patch set 34 11/10/22, 17:15
-
core-ci voted on patch set 34 V -1 11/10/22, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33521
-
Oli Bartsch uploaded patch set 35
V -111/23/22, 21:28 -
core-ci voted on patch set 35 V -1 11/23/22, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34138
-
Benni Mack uploaded patch set 36
V -111/28/22, 17:03 -
core-ci voted on patch set 36 V -1 11/28/22, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34333
-
Benni Mack uploaded patch set 37
V -111/28/22, 21:56 -
core-ci voted on patch set 37 V -1 11/28/22, 22:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34344
-
Oliver Hader commented on patch set 37 11/29/22, 13:56
Fields.html:13Fails when saving data `PHP Warning: Array to string conversion in /Users/olly/Development/typo3/main/typo3/sysext/core/Classes/DataHandling/DataHandler.php line 8339` -
Oliver Hader commented on patch set 37 11/29/22, 14:03
Fields.html:13ReplyForget it, requires that other pending JSON change -
Benni Mack uploaded patch set 38
V -111/29/22, 19:40 -
Oliver Hader uploaded patch set 39 11/29/22, 19:47
-
Oliver Hader uploaded patch set 40 11/29/22, 19:51
-
core-ci voted on patch set 38 V -1 11/29/22, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34372
-
Benni Mack uploaded patch set 41 11/29/22, 20:09
-
core-ci voted on patch set 39 V -1 11/29/22, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34375
-
core-ci voted on patch set 40 V -1 11/29/22, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34376
-
core-ci voted on patch set 41 V -1 11/29/22, 20:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34379
-
Benni Mack uploaded patch set 42
V -111/29/22, 21:05 -
core-ci voted on patch set 42 V -1 11/29/22, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34380
-
Oliver Hader uploaded patch set 43
V -111/29/22, 21:26 -
Oliver Hader uploaded patch set 44 11/29/22, 21:27
-
Oliver Hader uploaded patch set 45 11/29/22, 21:29
-
core-ci voted on patch set 43 V -1 11/29/22, 21:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34381
-
core-ci voted on patch set 44 V -1 11/29/22, 21:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34382
-
core-ci voted on patch set 45 V -1 11/29/22, 21:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34383
-
Benni Mack uploaded patch set 46
V -111/29/22, 22:33 -
core-ci voted on patch set 46 V -1 11/29/22, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34386
-
Benni Mack uploaded patch set 47
V -111/30/22, 09:39 -
core-ci voted on patch set 47 V -1 11/30/22, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34398
-
Benni Mack uploaded patch set 48
V -111/30/22, 10:43 -
core-ci voted on patch set 48 V -1 11/30/22, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34408
-
Stefan Bürk uploaded patch set 49
V -111/30/22, 12:13 -
Stefan Bürk commented on patch set 49 11/30/22, 12:15
* Required TF PR for verification -> https://github.com/TYPO3/testing-framework/pull/430 * Used correct BU method for database row encoded, as this has changed in the TCA type pre-patch * adjusted fixture csv for json field data import -
core-ci voted on patch set 49 V -1 11/30/22, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34417
-
Oli Bartsch uploaded patch set 50
V -111/30/22, 21:36 -
core-ci voted on patch set 50 V -1 11/30/22, 21:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34451
-
Oli Bartsch uploaded patch set 51
V -111/30/22, 22:28 -
core-ci voted on patch set 51 V -1 11/30/22, 22:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34455
-
Oli Bartsch uploaded patch set 52
V -112/01/22, 10:17 -
core-ci voted on patch set 52 V -1 12/01/22, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34464
-
Oli Bartsch uploaded patch set 53
V -112/01/22, 11:28 -
core-ci voted on patch set 53 V +1 12/01/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34473
-
Oli Bartsch uploaded patch set 54
V +112/01/22, 12:15 -
Oli Bartsch uploaded patch set 55 12/01/22, 12:30
-
core-ci voted on patch set 54 V +1 12/01/22, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34486
-
core-ci voted on patch set 55 V +1 12/01/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34489
-
Stefan Bürk uploaded patch set 56
V +112/01/22, 13:34 -
core-ci voted on patch set 56 V -1 12/01/22, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34498
-
Stefan Bürk uploaded patch set 57
V -112/01/22, 13:53 -
core-ci voted on patch set 57 V +1 12/01/22, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34500
-
Oliver Hader voted on patch set 57 CR +1 12/01/22, 14:47
-
Oli Bartsch voted on patch set 57 V +1 CR +1 12/01/22, 14:48
-
Stefan Bürk commented on patch set 57 CR -1 12/01/22, 15:12
-1 just as a reminder that this need's TF pr merged first .. as seeing raising votes. -
Stefan Bürk uploaded patch set 58
CR +1V +112/01/22, 15:23 -
Andreas Kienast commented on patch set 58 12/01/22, 15:27
composer.json:284ReplyDone -
core-ci voted on patch set 58 V +1 12/01/22, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34506
-
Andreas Kienast commented on patch set 58 CR -1 12/01/22, 15:50
on itReactionResolver.php:803rd step is missinglocallang_db.xlf:15Tabs and spaces mixedlocallang_module_reactions.xlf:37Tabs and spaces mixed -
Andreas Kienast uploaded patch set 59
CR -1V +112/01/22, 15:51 -
Andreas Kienast commented on patch set 59 V +1 CR +1 12/01/22, 15:52
ReactionResolver.php:80ReplyDonelocallang_db.xlf:15ReplyDonelocallang_module_reactions.xlf:37ReplyDone -
Oli Bartsch voted on patch set 59 V +1 CR +1 12/01/22, 15:54
-
Stefan Bürk commented on patch set 59 CR -1 12/01/22, 16:03
I think this patch should be rebased now because of merged: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76873 This patch adds another symfony component in version 6.1 -
core-ci voted on patch set 59 V +1 12/01/22, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34510
-
Andreas Kienast uploaded patch set 60
CR +1V +112/01/22, 16:08 -
Andreas Kienast commented on patch set 60 12/01/22, 16:08
Reply
Done -
Oli Bartsch uploaded patch set 61 12/01/22, 16:08
-
Andreas Kienast voted on patch set 60 V +1 CR +1 12/01/22, 16:08
-
Andreas Kienast voted on patch set 61 V +1 CR +1 12/01/22, 16:08
-
Oli Bartsch updated the commit message in patch set 62
CR +1V +112/01/22, 16:09 -
Andreas Kienast voted on patch set 62 V +1 CR +1 12/01/22, 16:10
-
Guido Schmechel wrote 12/01/22, 16:11
Removed cc Guido Schmechel. -
Oli Bartsch uploaded patch set 63
CR +1V +112/01/22, 16:12 -
Oli Bartsch voted on patch set 63 V +1 CR +1 12/01/22, 16:12
-
Andreas Kienast voted on patch set 63 V +1 CR +1 12/01/22, 16:22
-
core-ci voted on patch set 60 V -1 12/01/22, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34513
-
core-ci voted on patch set 61 V -1 12/01/22, 16:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34514
-
core-ci voted on patch set 62 V -1 12/01/22, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34515
-
core-ci voted on patch set 63 V -1 12/01/22, 16:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34516
-
Stefan Bürk commented on patch set 63 CR -1 12/01/22, 16:33
on it -
Stefan Bürk uploaded patch set 64
CR +1V +112/01/22, 16:35 -
Andreas Kienast voted on patch set 64 V +1 CR +1 12/01/22, 16:37
-
Benni Mack updated the commit message in patch set 65
CR +1V +112/01/22, 16:41 -
core-ci voted on patch set 64 V +1 12/01/22, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34518
-
Andreas Wolf commented on patch set 62 CR +1 12/01/22, 16:48
Looks good, just some minor things re. naming and some comment suggestions from my side.UuidElement.php:26"unique uid" != UUID (= "Universally unique identifier") "uid" in TYPO3 context is usually interpreted as an integer.ReactionItemsProcFunc.php:23"… to list tables available for reactions"?DataHandlerHook.php:38unique uid => UUIDDataHandlerHook.php:42unique uid => UUIDReactionHandler.php:30"calling the reaction handler" sounds a bit weird in a class that is called ReactionHandler.ReactionHandler.php:35* At this point, the evaluation etc. all need to have happened. The "have happened now" sounds like this is a change in behaviour in contrast to the code before (but this code is brand new).ReactionHandler.php:54"No reaction given" instead?ReactionHandler.php:58Should we include the identifier in the error message?ReactionHandler.php:61… before calling …CreateRecordReaction.php:92If the input is no string, we return it unchanged => that would fail here.ReactionRegistry.php:30Would it make sense to specify the type inside the \IteratorAggregate?ReactionDemand.php:49Can we probably promote some of these properties to class properties? -
core-ci voted on patch set 65 V +1 12/01/22, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34519
-
Andreas Kienast uploaded patch set 66
V +112/01/22, 17:56 -
Andreas Kienast commented on patch set 66 12/01/22, 17:57
UuidElement.php:26ReplyDoneReactionItemsProcFunc.php:23ReplyDoneDataHandlerHook.php:38ReplyDoneDataHandlerHook.php:42ReplyDoneReactionHandler.php:30ReplyDoneReactionHandler.php:35ReplyDoneReactionHandler.php:54ReplyDoneReactionHandler.php:58ReplyDoneReactionHandler.php:61ReplyDoneCreateRecordReaction.php:92ReplyWell keep it for now, it will fail anyway for now.ReactionRegistry.php:30ReplyDoneReactionDemand.php:49ReplyDone -
core-ci voted on patch set 66 V +1 12/01/22, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34522
-
Oli Bartsch voted on patch set 66 V +1 CR +1 12/01/22, 18:17
-
Andreas Kienast voted on patch set 66 V +1 CR +1 12/01/22, 18:17
-
Oli Bartsch uploaded patch set 67
CR +1V +112/01/22, 18:23 -
Oli Bartsch commented on patch set 67 V +1 CR +1 12/01/22, 18:25
ReactionHandler.php:58ReplyExposing the type identifier was skipped on purpose.CreateRecordReaction.php:92ReplyDone -
Andreas Kienast voted on patch set 67 V +1 CR +1 12/01/22, 18:25
-
Frank Nägler voted on patch set 67 V +1 CR +1 12/01/22, 18:26
-
Susi Moog voted on patch set 67 V +1 CR +1 12/01/22, 18:30
-
Andreas Wolf voted on patch set 67 CR +1 12/01/22, 18:30
-
core-ci voted on patch set 67 V +1 12/01/22, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34523
-
Oliver Hader voted on patch set 67 CR +1 12/01/22, 18:31
-
Benni Mack commented on patch set 67 V +1 CR +1 12/01/22, 18:35
YEAH. Merge conflict -
Oliver Hader voted on patch set 67 V +2 CR +2 12/01/22, 18:37
-
Benni Mack voted on patch set 67 V +2 CR +2 12/01/22, 18:39
-
Benni Mack merged patch set 68 12/01/22, 18:39
-
Benni Mack commented on patch set 68 12/01/22, 18:40
+2 eggs
icons.json:3969