Review main Merged

75482[FEATURE] Reactions - Incoming WebHooks for TYPO3

Frank Nägler CR +2 V +2 Nightmare +3258 −5 updated 12/01/22, 18:40

Commit message

This feature adds the possibility to receive incoming webhooks
into a TYPO3 instance.

This feature allows everybody to provide additional value for
any TYPO3 instance.

With the new system, a basic reaction is added, which allows
to create new records.

Extension authors are able to add their own reaction types
by implementing the ReactionInterface and adding corresponding
TCA configuration.

Used command(s)
  > composer req "symfony/uid:^6.2"
  > composer update typo3/testing-framework

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Benni Mack +2
    • Oli Bartsch +1
    • Frank Nägler +1
    • Andreas Kienast +1
    • Susi Moog +1
    • Andreas Wolf +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Benni Mack +2
    • Oli Bartsch +1
    • Frank Nägler +1
    • Andreas Kienast +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 44

Show 24 more files

Review log 135189

Show 114164 earlier messages
  1. Frank Nägler uploaded patch set 1 08/17/22, 15:32

  2. Frank Nägler uploaded patch set 2 08/17/22, 19:34

  3. Frank Nägler uploaded patch set 3 08/17/22, 22:02

  4. Frank Nägler uploaded patch set 4 08/18/22, 09:06

  5. Andreas Kienast commented on patch set 4 08/18/22, 12:54

    icons.json:3969

    Please do not modify this manually

    ManagementController.php:33

    Copy/pasta comment

    README.rst:2

    No no no no no ;)
  6. Frank Nägler commented on patch set 4 08/18/22, 12:58

    icons.json:3969 Reply

    > Please do not modify this manually must be changed later

    ManagementController.php:33 Reply

    Done

    README.rst:2 Reply

    Done
  7. Andreas Kienast commented on patch set 4 08/18/22, 13:00

    ReactionHandler.php:73

    I think this needs more conceptual work. I just checked Github, there I cannot configure the header name used to transmit the secret. Perhaps, such cases need a dedicated middleware to "translate" the headers.
  8. Frank Nägler commented on patch set 4 08/18/22, 13:17

    ReactionHandler.php:73 Reply

    Correct, this must be changed to get a parameter. The header idea is not useful in this context. Besides that, the whole auth part is something we have to discuss.
  9. Andreas Kienast commented on patch set 4 08/19/22, 05:12

    composer.lock:8514

    Please upgrade to Composer 2.3
  10. Frank Nägler uploaded patch set 5 08/22/22, 12:05

  11. Frank Nägler uploaded patch set 6 08/22/22, 12:54

  12. Frank Nägler uploaded patch set 7 08/22/22, 18:55

  13. Frank Nägler uploaded patch set 8 08/23/22, 08:09

  14. Oliver Hader commented on patch set 8 08/26/22, 07:19

    In general, I think the overall concept of "reactions" needs to be streamlined. The current behavior mimics the behavior of a web API, allowing to process data with a dedicated action (C*UD currently via CreateRecordReaction etc. - but no ReadRecordReaction). A reduced permission set is organized in new sys_reaction table. I currently these two directions: 1) Maybe we want to have a web API (REST? API) with generic authentication and generic permissions for any resource → that would not be related to the web-hook topic, but a general public API. Instead of a "user" the could be a "role" to grant particular permissions (CRUD, fields, TCA-types, modifications on child items, etc.). 2) Maybe we want to re-introduce sys_action, which allows to declare "completed" actions or adjust data by defined variables. A "sys_reaction" would then expose a particular "sys_action" to the web interface, giving it a name/identifier and some auth mechanism.

    ReactionHandler.php:55

    In case a website is vulnerable to SQL injection (e.g. through 3rd party code), these "secret keys" can directly be fetched from database and used to invoke a "reaction". Usually these "secrets" (or tokens) are only shown once during creation, and are stored hashed/salted in the database. Currently "secretKey" serves as password and as identifier - probably these two aspects should be separated and used explicitly.
  15. Oliver Hader commented on patch set 8 08/26/22, 07:25

    ReactionHandler.php:55 Reply

    Addition: I also would be possible to use asymmetric encryption on the actual payload - the secret key is only shown once to the client, when creating a new item in the backend, but the server only stores the public key. Each incoming request then either could to be encrypted, or at least needs to be signed - e.g. using https://tweetnacl.js.org/#/sign
  16. Oli Bartsch commented on patch set 8 09/02/22, 13:00

    kend

    DataHandlerHook.php:45

    We might want to use a new TCA type for this

    DataHandlerHook.php:54

    We might want to use a new TCA type for this

    ReactionHandler.php:29

    backend

    ReactionHandler.php:75

    This is currently triggered on every POST request.

    ReactionService.php:57

    We should just use the service from $registeredReactions here. Something link `$this->getReactionByIdentifier($reactionRecord['reaction'])`. public function getReactionByIdentifier(string $identifier): ?ReactionInterface { /** @var ReactionInterface $reaction */ foreach ($this->registeredReactions as $reaction) { if ($reaction->getIdentifier() === $identifier) { return $reaction; } } return null; }
  17. Oli Bartsch commented on patch set 8 09/02/22, 15:56

    ReactionHandler.php:73

    What do you think of using dedicated endpoints (speaking paths) instead of a random secret.

    ReactionInterface.php:26

    Current implementation (ReactionService) instances the reaction always based on the database value. Therefore, it should be mandatory to use the FQN, right?

    RecordReactionTrait.php:43

    Not important in current state but please lets use the PRS-17 factories here in the end.

    RecordReactionTrait.php:53

    What do you think of introducing another special user "_reactions_", similar to the "_cli_" user.

    ReactionService.php:29

    ReactionRegistry might be a better term, since this holds the registered reactions and also allows to access / use them. We also used this therm in core for latest - similar - introductions.

    AllowedTablesItemsProcFunc.php:20

    We might want to use existing `TYPO3\CMS\Core\Hooks\TcaItemsProcessorFunctions->populateAvailableTables()` here? - We might need to adjust it to allow checking of additional "filter fields".

    Modules.php:20

    Not used in the corresponding controller

    Pagination.html:39

    We might want to make use of the global event handler here instead. See usage e.g. in https://github.com/TYPO3/typo3/blob/main/typo3/sysext/beuser/Resources/Private/Partials/SimplePagination.html#L38
  18. Oli Bartsch commented on patch set 8 09/02/22, 15:57

    Reply

    Oops.. not intended
  19. Frank Nägler commented on patch set 8 09/05/22, 10:55

    Thank you all for the feedback. I will work on a new patchset the next days and will try to take care of all your feedback,

    Reply

    Yes, the first three implementations are a kind of CRUD implementation. I will remove that. The idea is more the implementation I made in the VisualCreateRecordReaction. Click records together that can be enriched with data from the payload.

    DataHandlerHook.php:45 Reply

    Ack

    DataHandlerHook.php:54 Reply

    Ack

    ReactionHandler.php:29 Reply

    Ack

    ReactionHandler.php:55 Reply

    I agree with the first part (show token only once, stored hashed). Regarding the second part, this must be optional because, e.g., GitHub will not sign or encrypt a request. The idea is to use any external request/payload to do something with that. Example: A new release is tagged on GitHub; create a tt_content record with a release announcement.

    ReactionHandler.php:73 Reply

    not sure, do you have a concrete example?

    ReactionHandler.php:75 Reply

    Ack

    ReactionInterface.php:26 Reply

    Ack

    RecordReactionTrait.php:43 Reply

    Ack

    RecordReactionTrait.php:53 Reply

    I agree; that is also the reason for the @TODO marker. This fake admin is to quickly test the PoC, which can't be the final solution and is also maybe a security risk.

    ReactionService.php:29 Reply

    Ack

    ReactionService.php:57 Reply

    Ack

    Modules.php:20 Reply

    Ack
  20. Frank Nägler uploaded patch set 9 09/06/22, 11:52

  21. Frank Nägler commented on patch set 9 09/06/22, 11:54

    DataHandlerHook.php:45 Reply

    Done

    ReactionHandler.php:29 Reply

    Done

    ReactionHandler.php:75 Reply

    Done

    ReactionInterface.php:26 Reply

    Done

    RecordReactionTrait.php:43 Reply

    Done

    ReactionService.php:29 Reply

    Done

    ReactionService.php:57 Reply

    Done

    AllowedTablesItemsProcFunc.php:20 Reply

    This is something we should talk about. Unfortunately, I am not sure we have the same understanding. I will ping you in the next few days.

    Modules.php:20 Reply

    Done

    Pagination.html:39 Reply

    works only with extbase controllers, but this is no extbase.
  22. Frank Nägler commented on patch set 9 09/06/22, 11:57

    ReactionHandler.php:73 Reply

    Done
  23. Frank Nägler uploaded patch set 10 09/14/22, 13:42

  24. Frank Nägler commented on patch set 10 09/14/22, 13:43

    composer.lock:8514 Reply

    Done
  25. Frank Nägler commented on patch set 10 09/15/22, 12:50

    DataHandlerHook.php:54 Reply

    Done
  26. Frank Nägler uploaded patch set 11 09/15/22, 12:50

  27. Frank Nägler uploaded patch set 12 09/15/22, 12:56

  28. Frank Nägler uploaded patch set 13 09/16/22, 09:26

  29. Frank Nägler commented on patch set 12 09/16/22, 09:26

    AllowedTablesItemsProcFunc.php:20 Reply

    Done
  30. Frank Nägler commented on patch set 13 09/19/22, 08:12

    Reply

    Done

    icons.json:3969 Reply

    Done

    ReactionHandler.php:55 Reply

    Done

    ReactionHandler.php:73 Reply

    Done
  31. Frank Nägler uploaded patch set 14 09/19/22, 08:13

  32. Frank Nägler uploaded patch set 15 09/19/22, 12:10

  33. Frank Nägler commented on patch set 15 09/19/22, 12:10

    RecordReactionTrait.php:53 Reply

    Done

    Pagination.html:39 Reply

    Done
  34. Frank Nägler wrote 09/19/22, 12:10

    Unset private
  35. core-ci voted on patch set 15 V -1 09/19/22, 12:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31266

  36. Frank Nägler uploaded patch set 16 09/19/22, 12:42

  37. core-ci voted on patch set 16 V -1 09/19/22, 12:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31269

  38. Frank Nägler uploaded patch set 17 09/19/22, 13:22

  39. core-ci voted on patch set 17 V -1 09/19/22, 13:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31272

  40. Guido Schmechel commented on patch set 17 09/19/22, 21:20

    Interesting topic, I am curious to see where the journey goes. So first of all, thank you for the great implementation and the (time) investment. I played around a bit, created a redirect, and here is my little feedback: - UX: I would like to be able to copy the secret with a button click ;-) - UX: I would include the URL in the edit form and display it. (One click less per action) - UX: It would also be nice if we could see an example JSON based on the allowed fields. You know: Users are lazy. - Code: I had a few PHP warnings with $tca['columns'] - Code: The reading of the fields should respect readOnly https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/ColumnsConfig/CommonProperties/ReadOnly.html - Code: The selection of fields is quite static in FieldMapElement. I would suggest adding a PSR 14 event here - Code: TcaItemsProcessorFunctions.php should also respect the TCA readOnly option https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/Ctrl/Properties/ReadOnly.html But important: In the end, a redirect was successfully created ;-)
  41. Frank Nägler uploaded patch set 18 09/20/22, 10:22

  42. Frank Nägler commented on patch set 17 09/20/22, 10:30

    Reply

    Thank you for your feedback. > - UX: I would like to be able to copy the secret with a button click ;-) This should be done in its own patch because this is a new FormElementWizard for the FormEngine, but it is a nice idea. > - UX: I would include the URL in the edit form and display it. (One click less per action) Good idea. I already added it to the edit form. > - UX: It would also be nice if we could see an example JSON based on the allowed fields. You know: Users are lazy. As discussed in private chat, this makes no sense because any payload is different and would confuse the user. > - Code: I had a few PHP warnings with $tca['columns'] Still open; I will check that next. > - Code: The reading of the fields should respect readOnly https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/ColumnsConfig/CommonProperties/ReadOnly.html > - Code: The selection of fields is quite static in FieldMapElement. I would suggest adding a PSR 14 event here > - Code: TcaItemsProcessorFunctions.php should also respect the TCA readOnly option https://docs.typo3.org/m/typo3/reference-tca/11.5/en-us/Ctrl/Properties/ReadOnly.html The editing interface needs more love, and I will talk about that topic with some UX/UI people. Only text input fields are supported at the moment. I added a TODO marker to make that more precise that this part is still open for the final patch. > But essential: In the end, a redirect was successfully created ;-) Yeah, that is nice 😊
  43. core-ci voted on patch set 18 V +1 09/20/22, 10:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31307

  44. Frank Nägler uploaded patch set 19 09/20/22, 11:29

  45. core-ci voted on patch set 19 V +1 09/20/22, 11:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31317

  46. Simon Schaufelberger commented on patch set 19 09/20/22, 20:47

    While Benni announced this cool new feature, I know that the Laravel community has a package for that already. Did you have a look at this? https://github.com/spatie/laravel-webhook-server https://github.com/spatie/laravel-webhook-client
  47. Simon Schaufelberger commented on patch set 19 09/20/22, 21:06

    Fields.html:4

    lang attribute can be removed, or?
  48. Frank Nägler uploaded patch set 20 09/21/22, 11:51

  49. Frank Nägler commented on patch set 20 09/21/22, 11:52

    Reply

    Thanks for your feedback, I know about the Laraval packages and checked other packages too. Most of the time, the problem with other packages is the integration in TYPO3 (bootstrap process, session, etc.),

    Fields.html:4 Reply

    Ack
  50. core-ci voted on patch set 20 V +1 09/21/22, 12:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31354

  51. Simon Schaufelberger commented on patch set 20 09/21/22, 12:24

    Reply

    Ack
  52. Simon Schaufelberger uploaded patch set 21 09/21/22, 14:43

  53. Simon Schaufelberger uploaded patch set 22 09/21/22, 14:44

  54. core-ci voted on patch set 21 V +1 09/21/22, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31378

  55. Simon Schaufelberger uploaded patch set 23 09/21/22, 14:56

  56. core-ci voted on patch set 22 V +1 09/21/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31379

  57. Simon Schaufelberger commented on patch set 23 09/21/22, 15:01

    ext_tables.sql:8

    since table is a reserved keyword, I checked what FAL and sys_refinxex is using and there it's "tablenames"/"tablename". Should we use "table_name"/"tablename" here instead?
  58. Simon Schaufelberger commented on patch set 23 09/21/22, 15:03

    I improved the fluid templates a bit, minified the svgs and some other minor things.
  59. core-ci voted on patch set 23 V +1 09/21/22, 15:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31381

  60. Simon Schaufelberger commented on patch set 23 V -1 09/21/22, 15:18

    InputSecretElement.php:60

    I've played with it and it crashes here with undefined array key "columns" when creating a new record.
  61. Frank Nägler commented on patch set 23 09/28/22, 11:39

    InputSecretElement.php:60 Reply

    Done

    ext_tables.sql:8 Reply

    Done
  62. Frank Nägler uploaded patch set 24 09/28/22, 11:40

  63. core-ci voted on patch set 24 V -1 09/28/22, 11:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31650

  64. core-ci commented on patch set 24 09/28/22, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31650

  65. Frank Nägler uploaded patch set 25 09/28/22, 13:05

  66. core-ci voted on patch set 25 V +1 09/28/22, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31654

  67. Benni Mack commented on patch set 25 10/04/22, 08:17

    How about moving the Secret Element as a common TCA type as a pre-patch / feature?
  68. Benni Mack uploaded patch set 26 10/04/22, 19:59

  69. core-ci voted on patch set 26 V +1 10/04/22, 20:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32012

  70. Frank Nägler commented on patch set 26 CR -1 10/06/22, 11:21

    Reply

    yes, will do that as a pre-patch and then update this patch
  71. Frank Nägler uploaded patch set 27 10/07/22, 14:31

  72. core-ci voted on patch set 27 V -1 10/07/22, 14:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32074

  73. Frank Nägler rebased onto patch set 28 10/07/22, 16:39

  74. core-ci voted on patch set 28 V +1 10/07/22, 16:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32078

  75. Frank Nägler uploaded patch set 29 10/07/22, 16:51

  76. Frank Nägler uploaded patch set 30 10/07/22, 16:54

  77. core-ci voted on patch set 29 V +1 10/07/22, 16:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32079

  78. core-ci voted on patch set 30 V +1 10/07/22, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32080

  79. Frank Nägler rebased onto patch set 31 10/18/22, 07:33

  80. core-ci voted on patch set 31 V +1 10/18/22, 07:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32415

  81. Oli Bartsch uploaded patch set 32 11/08/22, 22:08

  82. core-ci voted on patch set 32 V +1 11/08/22, 22:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33362

  83. Oli Bartsch uploaded patch set 33 11/10/22, 13:07

  84. Benni Mack commented on patch set 33 11/10/22, 13:08

    composer.json:284

    ordering is wrong here. (not alphabetical)
  85. core-ci voted on patch set 33 V +1 11/10/22, 13:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33492

  86. Oli Bartsch uploaded patch set 34 11/10/22, 17:15

  87. core-ci voted on patch set 34 V -1 11/10/22, 17:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/33521

  88. Oli Bartsch uploaded patch set 35 V -1 11/23/22, 21:28

  89. core-ci voted on patch set 35 V -1 11/23/22, 21:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34138

  90. Benni Mack uploaded patch set 36 V -1 11/28/22, 17:03

  91. core-ci voted on patch set 36 V -1 11/28/22, 17:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34333

  92. Benni Mack uploaded patch set 37 V -1 11/28/22, 21:56

  93. core-ci voted on patch set 37 V -1 11/28/22, 22:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34344

  94. Oliver Hader commented on patch set 37 11/29/22, 13:56

    Fields.html:13

    Fails when saving data `PHP Warning: Array to string conversion in /Users/olly/Development/typo3/main/typo3/sysext/core/Classes/DataHandling/DataHandler.php line 8339`
  95. Oliver Hader commented on patch set 37 11/29/22, 14:03

    Fields.html:13 Reply

    Forget it, requires that other pending JSON change
  96. Benni Mack uploaded patch set 38 V -1 11/29/22, 19:40

  97. Oliver Hader uploaded patch set 39 11/29/22, 19:47

  98. Oliver Hader uploaded patch set 40 11/29/22, 19:51

  99. core-ci voted on patch set 38 V -1 11/29/22, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34372

  100. Benni Mack uploaded patch set 41 11/29/22, 20:09

  101. core-ci voted on patch set 39 V -1 11/29/22, 20:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34375

  102. core-ci voted on patch set 40 V -1 11/29/22, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34376

  103. core-ci voted on patch set 41 V -1 11/29/22, 20:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34379

  104. Benni Mack uploaded patch set 42 V -1 11/29/22, 21:05

  105. core-ci voted on patch set 42 V -1 11/29/22, 21:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34380

  106. Oliver Hader uploaded patch set 43 V -1 11/29/22, 21:26

  107. Oliver Hader uploaded patch set 44 11/29/22, 21:27

  108. Oliver Hader uploaded patch set 45 11/29/22, 21:29

  109. core-ci voted on patch set 43 V -1 11/29/22, 21:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34381

  110. core-ci voted on patch set 44 V -1 11/29/22, 21:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34382

  111. core-ci voted on patch set 45 V -1 11/29/22, 21:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34383

  112. Benni Mack uploaded patch set 46 V -1 11/29/22, 22:33

  113. core-ci voted on patch set 46 V -1 11/29/22, 22:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34386

  114. Benni Mack uploaded patch set 47 V -1 11/30/22, 09:39

  115. core-ci voted on patch set 47 V -1 11/30/22, 10:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34398

  116. Benni Mack uploaded patch set 48 V -1 11/30/22, 10:43

  117. core-ci voted on patch set 48 V -1 11/30/22, 11:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34408

  118. Stefan Bürk uploaded patch set 49 V -1 11/30/22, 12:13

  119. Stefan Bürk commented on patch set 49 11/30/22, 12:15

    * Required TF PR for verification -> https://github.com/TYPO3/testing-framework/pull/430 * Used correct BU method for database row encoded, as this has changed in the TCA type pre-patch * adjusted fixture csv for json field data import
  120. core-ci voted on patch set 49 V -1 11/30/22, 12:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34417

  121. Oli Bartsch uploaded patch set 50 V -1 11/30/22, 21:36

  122. core-ci voted on patch set 50 V -1 11/30/22, 21:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34451

  123. Oli Bartsch uploaded patch set 51 V -1 11/30/22, 22:28

  124. core-ci voted on patch set 51 V -1 11/30/22, 22:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34455

  125. Oli Bartsch uploaded patch set 52 V -1 12/01/22, 10:17

  126. core-ci voted on patch set 52 V -1 12/01/22, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34464

  127. Oli Bartsch uploaded patch set 53 V -1 12/01/22, 11:28

  128. core-ci voted on patch set 53 V +1 12/01/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34473

  129. Oli Bartsch uploaded patch set 54 V +1 12/01/22, 12:15

  130. Oli Bartsch uploaded patch set 55 12/01/22, 12:30

  131. core-ci voted on patch set 54 V +1 12/01/22, 12:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34486

  132. core-ci voted on patch set 55 V +1 12/01/22, 12:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34489

  133. Stefan Bürk uploaded patch set 56 V +1 12/01/22, 13:34

  134. core-ci voted on patch set 56 V -1 12/01/22, 13:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34498

  135. Stefan Bürk uploaded patch set 57 V -1 12/01/22, 13:53

  136. core-ci voted on patch set 57 V +1 12/01/22, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34500

  137. Oliver Hader voted on patch set 57 CR +1 12/01/22, 14:47

  138. Oli Bartsch voted on patch set 57 V +1 CR +1 12/01/22, 14:48

  139. Stefan Bürk commented on patch set 57 CR -1 12/01/22, 15:12

    -1 just as a reminder that this need's TF pr merged first .. as seeing raising votes.
  140. Stefan Bürk uploaded patch set 58 CR +1 V +1 12/01/22, 15:23

  141. Stefan Bürk commented on patch set 58 12/01/22, 15:23

    Reply

    Done

    Reply

    Done
  142. Andreas Kienast commented on patch set 58 12/01/22, 15:27

    composer.json:284 Reply

    Done
  143. core-ci voted on patch set 58 V +1 12/01/22, 15:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34506

  144. Andreas Kienast commented on patch set 58 CR -1 12/01/22, 15:50

    on it

    ReactionResolver.php:80

    3rd step is missing

    locallang_db.xlf:15

    Tabs and spaces mixed

    locallang_module_reactions.xlf:37

    Tabs and spaces mixed
  145. Andreas Kienast uploaded patch set 59 CR -1 V +1 12/01/22, 15:51

  146. Andreas Kienast commented on patch set 59 V +1 CR +1 12/01/22, 15:52

    ReactionResolver.php:80 Reply

    Done

    locallang_db.xlf:15 Reply

    Done

    locallang_module_reactions.xlf:37 Reply

    Done
  147. Oli Bartsch voted on patch set 59 V +1 CR +1 12/01/22, 15:54

  148. Stefan Bürk commented on patch set 59 CR -1 12/01/22, 16:03

    I think this patch should be rebased now because of merged: https://review.typo3.org/c/Packages/TYPO3.CMS/+/76873 This patch adds another symfony component in version 6.1
  149. core-ci voted on patch set 59 V +1 12/01/22, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34510

  150. Andreas Kienast uploaded patch set 60 CR +1 V +1 12/01/22, 16:08

  151. Andreas Kienast commented on patch set 60 12/01/22, 16:08

    Reply

    Done
  152. Oli Bartsch uploaded patch set 61 12/01/22, 16:08

  153. Andreas Kienast voted on patch set 60 V +1 CR +1 12/01/22, 16:08

  154. Andreas Kienast voted on patch set 61 V +1 CR +1 12/01/22, 16:08

  155. Oli Bartsch updated the commit message in patch set 62 CR +1 V +1 12/01/22, 16:09

  156. Andreas Kienast voted on patch set 62 V +1 CR +1 12/01/22, 16:10

  157. Guido Schmechel wrote 12/01/22, 16:11

    Removed cc Guido Schmechel.
  158. Oli Bartsch uploaded patch set 63 CR +1 V +1 12/01/22, 16:12

  159. Oli Bartsch voted on patch set 63 V +1 CR +1 12/01/22, 16:12

  160. Andreas Kienast voted on patch set 63 V +1 CR +1 12/01/22, 16:22

  161. core-ci voted on patch set 60 V -1 12/01/22, 16:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34513

  162. core-ci voted on patch set 61 V -1 12/01/22, 16:28 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34514

  163. core-ci voted on patch set 62 V -1 12/01/22, 16:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34515

  164. core-ci voted on patch set 63 V -1 12/01/22, 16:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34516

  1. Stefan Bürk commented on patch set 63 CR -1 12/01/22, 16:33

    on it
  2. Stefan Bürk uploaded patch set 64 CR +1 V +1 12/01/22, 16:35

  3. Andreas Kienast voted on patch set 64 V +1 CR +1 12/01/22, 16:37

  4. Benni Mack updated the commit message in patch set 65 CR +1 V +1 12/01/22, 16:41

  5. core-ci voted on patch set 64 V +1 12/01/22, 16:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34518

  6. Andreas Wolf commented on patch set 62 CR +1 12/01/22, 16:48

    Looks good, just some minor things re. naming and some comment suggestions from my side.

    UuidElement.php:26

    "unique uid" != UUID (= "Universally unique identifier") "uid" in TYPO3 context is usually interpreted as an integer.

    ReactionItemsProcFunc.php:23

    "… to list tables available for reactions"?

    DataHandlerHook.php:38

    unique uid => UUID

    DataHandlerHook.php:42

    unique uid => UUID

    ReactionHandler.php:30

    "calling the reaction handler" sounds a bit weird in a class that is called ReactionHandler.

    ReactionHandler.php:35

    * At this point, the evaluation etc. all need to have happened. The "have happened now" sounds like this is a change in behaviour in contrast to the code before (but this code is brand new).

    ReactionHandler.php:54

    "No reaction given" instead?

    ReactionHandler.php:58

    Should we include the identifier in the error message?

    ReactionHandler.php:61

    … before calling …

    CreateRecordReaction.php:92

    If the input is no string, we return it unchanged => that would fail here.

    ReactionRegistry.php:30

    Would it make sense to specify the type inside the \IteratorAggregate?

    ReactionDemand.php:49

    Can we probably promote some of these properties to class properties?
  7. core-ci voted on patch set 65 V +1 12/01/22, 16:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34519

  8. Andreas Kienast uploaded patch set 66 V +1 12/01/22, 17:56

  9. Andreas Kienast commented on patch set 66 12/01/22, 17:57

    UuidElement.php:26 Reply

    Done

    ReactionItemsProcFunc.php:23 Reply

    Done

    DataHandlerHook.php:38 Reply

    Done

    DataHandlerHook.php:42 Reply

    Done

    ReactionHandler.php:30 Reply

    Done

    ReactionHandler.php:35 Reply

    Done

    ReactionHandler.php:54 Reply

    Done

    ReactionHandler.php:58 Reply

    Done

    ReactionHandler.php:61 Reply

    Done

    CreateRecordReaction.php:92 Reply

    Well keep it for now, it will fail anyway for now.

    ReactionRegistry.php:30 Reply

    Done

    ReactionDemand.php:49 Reply

    Done
  10. core-ci voted on patch set 66 V +1 12/01/22, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34522

  11. Oli Bartsch voted on patch set 66 V +1 CR +1 12/01/22, 18:17

  12. Andreas Kienast voted on patch set 66 V +1 CR +1 12/01/22, 18:17

  13. Oli Bartsch uploaded patch set 67 CR +1 V +1 12/01/22, 18:23

  14. Oli Bartsch commented on patch set 67 V +1 CR +1 12/01/22, 18:25

    ReactionHandler.php:58 Reply

    Exposing the type identifier was skipped on purpose.

    CreateRecordReaction.php:92 Reply

    Done
  15. Andreas Kienast voted on patch set 67 V +1 CR +1 12/01/22, 18:25

  16. Frank Nägler voted on patch set 67 V +1 CR +1 12/01/22, 18:26

  17. Susi Moog voted on patch set 67 V +1 CR +1 12/01/22, 18:30

  18. Andreas Wolf voted on patch set 67 CR +1 12/01/22, 18:30

  19. core-ci voted on patch set 67 V +1 12/01/22, 18:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/34523

  20. Oliver Hader voted on patch set 67 CR +1 12/01/22, 18:31

  21. Benni Mack commented on patch set 67 V +1 CR +1 12/01/22, 18:35

    YEAH. Merge conflict
  22. Oliver Hader voted on patch set 67 V +2 CR +2 12/01/22, 18:37

  23. Benni Mack voted on patch set 67 V +2 CR +2 12/01/22, 18:39

  24. Benni Mack merged patch set 68 12/01/22, 18:39

  25. Benni Mack commented on patch set 68 12/01/22, 18:40

    +2 eggs