Review main Merged

75484[BUGFIX] Avoid undefined array keys error using stdWrap_bytes

Chris Müller CR +2 V +2 Easy +14 −4 updated 08/19/22, 09:31

Commit message

If either labels or base are not given, the default values
kick in: labels = iec and base = 1024

With the new fallback values in place test ContentObjectRendererTest
notAllStdWrapProcessorsAreCallableWithEmptyConfiguration()
needs a minor adaption.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1116

  1. Chris Müller uploaded patch set 1 08/17/22, 18:36

  2. core-ci voted on patch set 1 V +1 08/17/22, 18:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30249

  3. Benni Mack voted on patch set 1 V +1 CR +1 08/18/22, 08:38

  4. Christian Kuhn uploaded patch set 2 08/19/22, 08:13

  5. Christian Kuhn updated the commit message in patch set 3 08/19/22, 08:14

  6. Christian Kuhn voted on patch set 3 V +1 CR +1 08/19/22, 08:14

  7. Benni Mack voted on patch set 3 V +1 CR +1 08/19/22, 08:15

  8. core-ci voted on patch set 2 V -1 08/19/22, 08:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30291

  9. core-ci voted on patch set 3 V -1 08/19/22, 08:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30292

  10. core-ci commented on patch set 3 08/19/22, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30292

  11. Christian Kuhn commented on patch set 3 08/19/22, 08:53

    red core-ci is a side effect in current main. will be fixed. this patch will then be rebased again.
  12. Christian Kuhn rebased onto patch set 4 08/19/22, 09:14

  13. Andreas Kienast voted on patch set 4 V +1 CR +1 08/19/22, 09:28

  14. core-ci voted on patch set 4 V +1 08/19/22, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30300

  15. Christian Kuhn voted on patch set 4 V +2 CR +2 08/19/22, 09:31

  16. Christian Kuhn merged patch set 5 08/19/22, 09:31