75485[!!!][TASK] Remove TypoScript option page.CSS_inlineStyle
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
-
Verified V +2 Done
- Oli Bartsch +2
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98312-TypoScriptSettingPageCSS_inlineStyleRemoved.rstnew+48 −0
- typo3/sysext/frontend/Classes/Http/RequestHandler.php+1 −3
- typo3/sysext/frontend/Tests/Unit/Http/RequestHandlerTest.php+4 −4
- typo3/sysext/t3editor/Resources/Private/tsref.xml+0 −5
- typo3/sysext/t3editor/Resources/Public/JavaScript/Mode/typoscript/typoscript.js+0 −1
Review log 913
-
Benni Mack uploaded patch set 1 08/17/22, 19:02
-
core-ci voted on patch set 1 V -1 08/17/22, 19:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30250
-
Stefan Bürk uploaded patch set 2 08/23/22, 19:51
-
core-ci voted on patch set 2 V +1 08/23/22, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30389
-
Benni Mack uploaded patch set 3 09/09/22, 12:15
-
Andreas Kienast updated the commit message in patch set 4 09/09/22, 12:18
-
Andreas Kienast voted on patch set 4 V +1 CR +1 09/09/22, 12:20
-
core-ci voted on patch set 3 V +1 09/09/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30925
-
core-ci voted on patch set 4 V +1 09/09/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30927
-
Oli Bartsch voted on patch set 4 V +2 CR +2 09/12/22, 12:07
-
Oli Bartsch merged patch set 5 09/12/22, 12:07
-
Lina Wolf commented on patch set 5 09/13/22, 19:55
What about `config.inlineStyle2TempFile`? Is this still needed? -
Benni Mack commented on patch set 5 09/14/22, 06:29
Reply
Yes. this config option still applies to page.cssInline, plugin._CSS_PAGE_STYLE and plugin._CSS_DEFAULT_STYLE