Review main Merged Breaking

75485[!!!][TASK] Remove TypoScript option page.CSS_inlineStyle

Benni Mack CR +2 V +2 Normal +53 −13 updated 09/14/22, 06:29

Commit message

In order to consolidate TypoScript options,
the TypoScript option page.CSS_inlineStyle is removed
in favor of the much more flexible page.cssInline
which allows to add multiple inline settings and is
available since TYPO3 v4.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 913

  1. Benni Mack uploaded patch set 1 08/17/22, 19:02

  2. core-ci voted on patch set 1 V -1 08/17/22, 19:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30250

  3. Stefan Bürk uploaded patch set 2 08/23/22, 19:51

  4. core-ci voted on patch set 2 V +1 08/23/22, 19:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30389

  5. Benni Mack uploaded patch set 3 09/09/22, 12:15

  6. Andreas Kienast updated the commit message in patch set 4 09/09/22, 12:18

  7. Andreas Kienast voted on patch set 4 V +1 CR +1 09/09/22, 12:20

  8. core-ci voted on patch set 3 V +1 09/09/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30925

  9. core-ci voted on patch set 4 V +1 09/09/22, 12:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30927

  10. Oli Bartsch voted on patch set 4 V +2 CR +2 09/12/22, 12:07

  11. Oli Bartsch merged patch set 5 09/12/22, 12:07

  12. Lina Wolf commented on patch set 5 09/13/22, 19:55

    What about `config.inlineStyle2TempFile`? Is this still needed?
  13. Benni Mack commented on patch set 5 09/14/22, 06:29

    Reply

    Yes. this config option still applies to page.cssInline, plugin._CSS_PAGE_STYLE and plugin._CSS_DEFAULT_STYLE