Review main Merged

75488[TASK] Allow `Element` and `DocumentFragment` in now stricter Modal API

Andreas Kienast CR +2 V +2 Normal +26 −29 updated 08/19/22, 05:14

Commit message

The configuration definition of `content` in the Modal API is extended
to accept objects of types `Element` and `DocumentFragment` as well,
which allows passing arbitrary DOM nodes to the API, if TypeScript is
used. Since jQuery is still the main actor in the Modal API, no further
adjustments are required for now as jQuery can consume the added types.

In the same run, the API definition got stricter as `Modal.advanced()`
allowed to pass any arbitrary configuration not covered by the internal
`Configuration` interface.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benjamin Franzke +1
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Andreas Kienast uploaded patch set 1 08/18/22, 08:58

  2. core-ci voted on patch set 1 V +1 08/18/22, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30262

  3. Andreas Kienast uploaded patch set 2 08/18/22, 10:24

  4. Andreas Kienast uploaded patch set 3 08/18/22, 10:25

  5. core-ci voted on patch set 2 V +1 08/18/22, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30265

  6. core-ci voted on patch set 3 V +1 08/18/22, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30266

  7. Frank Nägler voted on patch set 3 CR +1 08/18/22, 10:59

  8. Frank Nägler voted on patch set 3 V +1 08/18/22, 11:56

  9. Benjamin Franzke commented on patch set 3 V +1 CR +1 08/18/22, 19:09

    modal.ts:382

    Change looks unrelated. Is this a real fix? I wonder if we need a 11.5 backport. Anyway, I'm fine with it in case this is needed for later patches.
  10. Andreas Kienast commented on patch set 3 08/18/22, 19:17

    modal.ts:382 Reply

    11.5 is not mandatory. The fix here is that a SeverityEnum is now fetched. Previously, TS was convinced we get a string, which is incompatible with the Configuration definition.
  11. Andreas Kienast voted on patch set 3 V +2 CR +2 08/19/22, 05:13

  12. Andreas Kienast merged patch set 4 08/19/22, 05:14