75488[TASK] Allow `Element` and `DocumentFragment` in now stricter Modal API
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Frank Nägler +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Frank Nägler +1
- core-ci +1 CI
Issues 1
Files 2
Review log 912
-
Andreas Kienast uploaded patch set 1 08/18/22, 08:58
-
core-ci voted on patch set 1 V +1 08/18/22, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30262
-
Andreas Kienast uploaded patch set 2 08/18/22, 10:24
-
Andreas Kienast uploaded patch set 3 08/18/22, 10:25
-
core-ci voted on patch set 2 V +1 08/18/22, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30265
-
core-ci voted on patch set 3 V +1 08/18/22, 10:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30266
-
Frank Nägler voted on patch set 3 CR +1 08/18/22, 10:59
-
Frank Nägler voted on patch set 3 V +1 08/18/22, 11:56
-
Benjamin Franzke commented on patch set 3 V +1 CR +1 08/18/22, 19:09
-
Andreas Kienast commented on patch set 3 08/18/22, 19:17
modal.ts:382Reply11.5 is not mandatory. The fix here is that a SeverityEnum is now fetched. Previously, TS was convinced we get a string, which is incompatible with the Configuration definition. -
Andreas Kienast voted on patch set 3 V +2 CR +2 08/19/22, 05:13
-
Andreas Kienast merged patch set 4 08/19/22, 05:14
modal.ts:382