75491[TASK] Pass dataset to context menu actions and drop jQuery in them
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Christian Kuhn +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Christian Kuhn +1
- core-ci +1 CI
Issues 1
Files 9
- Build/Sources/TypeScript/backend/context-menu-actions.ts+39 −106
- Build/Sources/TypeScript/backend/context-menu.ts4+25 −10
- Build/Sources/TypeScript/filelist/context-menu-actions.ts+30 −34
- Build/Sources/TypeScript/impexp/context-menu-actions.ts+4 −6
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/context-menu.js+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Deprecation-98168-BindingContextMenuItemToThis.rstnew+54 −0
- typo3/sysext/filelist/Resources/Public/JavaScript/context-menu-actions.js+1 −1
- typo3/sysext/impexp/Resources/Public/JavaScript/context-menu-actions.js+1 −1
Review log 912
-
Andreas Kienast uploaded patch set 1 08/18/22, 12:28
-
core-ci voted on patch set 1 V +1 08/18/22, 12:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30270
-
Andreas Kienast commented on patch set 1 CR -1 08/19/22, 06:13
On it -
Andreas Kienast uploaded patch set 2 08/19/22, 06:27
-
core-ci voted on patch set 2 V +1 08/19/22, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30287
-
Benjamin Franzke commented on patch set 2 CR -1 08/19/22, 07:12
on itcontext-menu.ts:222Shouldn't we directly use event.currentTarget.dataset instead? I mean, jQuery .data() does a little more, like type covnersion (string to number), so it seems to be better to use vanilla dataset in order for code to be updated right now and be compatible with usage without jquery later on.context-menu.ts:225This warning will always be printed, regardless whether this is used or not. Maybe use a Proxy instead? -
Benjamin Franzke uploaded patch set 3 08/19/22, 07:20
-
Benjamin Franzke commented on patch set 3 08/19/22, 07:20
context-menu.ts:222ReplyDone, switched to .dataset. This way also DOMStringMap annotation on the callbacks is more safe. (as written, because .data() performs type conversions)context-menu.ts:225ReplyDone -
core-ci voted on patch set 3 V +1 08/19/22, 07:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30290
-
Christian Kuhn voted on patch set 3 V +1 CR +1 08/19/22, 09:20
-
Andreas Kienast voted on patch set 3 V +2 CR +2 08/19/22, 09:20
-
Andreas Kienast merged patch set 4 08/19/22, 09:20