Review 11.5 Merged

75492[BUGFIX] Fix page reloading on click on preview button

Tobias Jungmann CR +2 V +2 Normal +84 −11 updated 08/24/22, 11:16

Commit message

If a preview page is already open, clicking on the "view" button in the
content editor window would not reload the page. That means, that the
preview page would not show changes if the preview page url and the
target url are similar (e.g. only differentiate in hash/query or are
exactly the same).

This patch looks if a window with the given windowName is already open
(looking in `this.windows` did not work well because the existing
windows aren't saved in a global context, yet) and compares the URL of
an open window (if there's one) with the given URL. If the URLs are
similiar (i.e. the origin and the path name are the same) the page will
be reloaded.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 2028

Show 23 earlier messages
  1. Tobias Jungmann commented on patch set 1 08/16/22, 06:34

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/form-engine.ts * Build/Sources/TypeScript/backend/utility.ts * Build/Sources/TypeScript/backend/window-manager.ts * typo3/sysext/backend/Resources/Public/JavaScript/form-engine.js * typo3/sysext/backend/Resources/Public/JavaScript/utility.js * typo3/sysext/backend/Resources/Public/JavaScript/window-manager.js
  2. core-ci voted on patch set 1 V -1 08/16/22, 08:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30186

  3. Tobias Jungmann uploaded patch set 2 08/16/22, 11:17

  1. Tobias Jungmann marked it ready for review 08/16/22, 11:18

  2. core-ci voted on patch set 2 V -1 08/16/22, 11:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30198

  3. core-ci commented on patch set 2 08/16/22, 13:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30198

  4. Stefan Bürk uploaded patch set 3 08/17/22, 06:44

  5. core-ci voted on patch set 3 V +1 08/17/22, 06:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30215

  6. Stefan Bürk commented on patch set 3 CR -1 08/17/22, 07:10

    ci green -- but locally tests are still failing lige in pipeline for patchset 2 ....
  7. Tobias Jungmann commented on patch set 3 08/17/22, 07:17

    Reply

    I'm on it. The test is "too fast". Wants to fetch the url of the new window and gets `about:blank?...`. Using a short timeout works. It seems that the patch reduces the performance some milliseconds. I'm looking for a solution.
  8. Tobias Jungmann uploaded patch set 4 08/22/22, 09:00

  9. core-ci voted on patch set 4 V +1 08/22/22, 09:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30344

  10. Tobias Jungmann commented on patch set 4 08/22/22, 09:49

    Reply

    Fixed it. Please review this patch.
  11. Björn Jacob voted on patch set 4 V +1 CR +1 08/22/22, 10:20

  12. Andreas Häfner voted on patch set 4 V +1 CR +1 08/22/22, 11:22

  13. Tobias Jungmann commented on patch set 4 CR -1 08/22/22, 17:04

    There are issus in the main branch. Will fix them here after positive feedback from main.
  14. Benjamin Franzke uploaded patch set 5 08/23/22, 20:32

  15. core-ci voted on patch set 5 V +1 08/23/22, 20:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30390

  16. Benjamin Franzke uploaded patch set 6 08/24/22, 06:09

  17. core-ci voted on patch set 6 V +1 08/24/22, 06:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30399

  18. Stefan Bürk uploaded patch set 7 08/24/22, 10:46

  19. Stefan Bürk commented on patch set 7 CR -1 08/24/22, 10:50

    Sorry, my bad - will repush patchset 6 from Benjamin Franzke
  20. Stefan Bürk uploaded patch set 8 08/24/22, 10:51

  21. Benjamin Franzke voted on patch set 8 V +1 CR +1 08/24/22, 10:59

  22. core-ci voted on patch set 8 V +1 08/24/22, 11:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30408

  23. Stefan Bürk voted on patch set 8 V +1 CR +1 08/24/22, 11:13

  24. Stefan Bürk voted on patch set 8 V +2 CR +2 08/24/22, 11:15

  25. Stefan Bürk merged patch set 9 08/24/22, 11:16