Review 11.5 Merged

75515[TASK] Allow `Element` and `DocumentFragment` in now stricter Modal API

Andreas Kienast CR +2 V +2 Normal +26 −29 updated 08/19/22, 05:24

Commit message

The configuration definition of `content` in the Modal API is extended
to accept objects of types `Element` and `DocumentFragment` as well,
which allows passing arbitrary DOM nodes to the API, if TypeScript is
used. Since jQuery is still the main actor in the Modal API, no further
adjustments are required for now as jQuery can consume the added types.

In the same run, the API definition got stricter as `Modal.advanced()`
allowed to pass any arbitrary configuration not covered by the internal
`Configuration` interface.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast uploaded patch set 1 08/19/22, 05:14

  2. core-ci voted on patch set 1 V +1 08/19/22, 05:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30286

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 08/19/22, 05:24

  4. Andreas Kienast merged patch set 2 08/19/22, 05:24