Review main Merged

75517[BUGFIX] Convert Node to DocumentFragment for modal consumption in EXT:dashboard

Andreas Kienast CR +2 V +2 Easy +12 −4 updated 08/19/22, 09:13

Commit message

The patches #98164 and #98165 conflicted with each other as one made
the modal API stricter while the other populated the modal with a
soon-to-be invalid configuration. This currently breaks all subsequent
builds.

The modals received objects of type `Node` which are not consumable by
jQuery's `append()` method. To solve this issue, `Node` is now converted
to a `DocumentFragment`, which can be consumed by all involved parties.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 4

Review log 45

  1. Andreas Kienast uploaded patch set 1 08/19/22, 09:05

  2. core-ci voted on patch set 1 V +1 08/19/22, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30297

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 08/19/22, 09:13

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 08/19/22, 09:13

  5. Andreas Kienast merged patch set 2 08/19/22, 09:13