Review main Abandoned

75522[WIP][TASK] TypoScript parser

Christian Kuhn CR 0 V 0 Normal +82 −33 updated 02/01/23, 08:30

Commit message

* maybe rename page.cache.<pid> syntax, since that is constant
  aware for identifiers and that's something we shouldn't support?
* {$foo} = bar needs hardening and should explode with good message,
  look up tests for current state
* foo < {$bar} needs hardening and should explode with good message,
  look up tests for current state
* cache behavior: changes on sys_template rows are transparent, changes
  on include files are not.
* docs reminder: a new condition after existing condition auto-closes
  existing condition, even if there is no [end]

Review

  • Code review CR 0
  • Verified V 0

Files 7

Review log 4076

Show 2751 earlier messages
  1. Christian Kuhn uploaded patch set 1 08/19/22, 13:05

  2. Christian Kuhn marked it work in progress 08/19/22, 13:06

  3. core-ci voted on patch set 1 V -1 08/19/22, 13:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30321

  4. Christian Kuhn commented on patch set 1 08/24/22, 05:37

  5. Christian Kuhn uploaded patch set 2 08/24/22, 17:17

  6. core-ci voted on patch set 2 V -1 08/24/22, 17:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30423

  7. Christian Kuhn uploaded patch set 3 08/24/22, 17:57

  8. core-ci voted on patch set 3 V -1 08/24/22, 18:04 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30424

  9. Christian Kuhn uploaded patch set 4 08/24/22, 18:18

  10. core-ci voted on patch set 4 V +1 08/24/22, 18:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30425

  11. Christian Kuhn uploaded patch set 5 08/24/22, 20:28

  12. core-ci voted on patch set 5 V -1 08/24/22, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30426

  13. Christian Kuhn uploaded patch set 6 08/29/22, 13:21

  14. core-ci voted on patch set 6 V -1 08/29/22, 13:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30520

  15. Christian Kuhn uploaded patch set 7 08/31/22, 23:19

  16. core-ci voted on patch set 7 V -1 08/31/22, 23:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30565

  17. Christian Kuhn uploaded patch set 8 09/07/22, 10:53

  18. core-ci voted on patch set 8 V -1 09/07/22, 11:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30736

  19. Christian Kuhn uploaded patch set 9 09/08/22, 17:22

  20. core-ci voted on patch set 9 V -1 09/08/22, 17:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30855

  21. Christian Kuhn uploaded patch set 10 09/08/22, 22:34

  22. core-ci voted on patch set 10 V -1 09/08/22, 22:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30868

  23. Christian Kuhn uploaded patch set 11 09/12/22, 15:40

  24. core-ci voted on patch set 11 V -1 09/12/22, 15:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30983

  25. Christian Kuhn uploaded patch set 12 09/13/22, 10:45

  26. core-ci voted on patch set 12 V -1 09/13/22, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31048

  27. Christian Kuhn uploaded patch set 13 09/14/22, 16:10

  28. core-ci voted on patch set 13 V -1 09/14/22, 16:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31089

  29. Christian Kuhn uploaded patch set 14 09/15/22, 05:48

  30. core-ci voted on patch set 14 V -1 09/15/22, 05:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31096

  31. Christian Kuhn uploaded patch set 15 09/15/22, 06:30

  32. core-ci voted on patch set 15 V -1 09/15/22, 06:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31097

  33. Christian Kuhn uploaded patch set 16 09/16/22, 07:44

  34. core-ci voted on patch set 16 V -1 09/16/22, 07:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31150

  35. Christian Kuhn uploaded patch set 17 09/16/22, 08:13

  36. core-ci voted on patch set 17 V +1 09/16/22, 08:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31151

  37. Christian Kuhn uploaded patch set 18 09/19/22, 18:02

  38. core-ci voted on patch set 18 V +1 09/19/22, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31285

  39. Christian Kuhn rebased onto patch set 19 10/01/22, 08:44

  40. core-ci voted on patch set 19 V +1 10/01/22, 08:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31807

  41. Christian Kuhn uploaded patch set 20 10/01/22, 10:23

  42. Christian Kuhn uploaded patch set 21 10/01/22, 10:56

  43. core-ci voted on patch set 20 V -1 10/01/22, 10:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31812

  44. core-ci voted on patch set 21 V +1 10/01/22, 11:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31813

  45. Christian Kuhn uploaded patch set 22 10/01/22, 11:45

  46. core-ci voted on patch set 22 V +1 10/01/22, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31816

  47. Christian Kuhn uploaded patch set 23 10/01/22, 13:20

  48. core-ci voted on patch set 23 V +1 10/01/22, 13:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31818

  49. Christian Kuhn uploaded patch set 24 10/01/22, 13:53

  50. Christian Kuhn uploaded patch set 25 10/01/22, 13:56

  51. core-ci voted on patch set 24 V +1 10/01/22, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31821

  1. core-ci voted on patch set 25 V +1 10/01/22, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31822

  2. Christian Kuhn uploaded patch set 26 10/01/22, 14:23

  3. Christian Kuhn uploaded patch set 27 10/01/22, 14:31

  4. core-ci voted on patch set 26 V -1 10/01/22, 14:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31825

  5. core-ci voted on patch set 27 V -1 10/01/22, 14:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31827

  6. Christian Kuhn uploaded patch set 28 10/01/22, 15:15

  7. core-ci voted on patch set 28 V +1 10/01/22, 15:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31831

  8. Christian Kuhn uploaded patch set 29 10/02/22, 00:12

  9. core-ci voted on patch set 29 V -1 10/02/22, 00:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31852

  10. Christian Kuhn uploaded patch set 30 10/02/22, 20:26

  11. Christian Kuhn rebased onto patch set 31 10/02/22, 20:33

  12. core-ci voted on patch set 30 V -1 10/02/22, 20:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31913

  13. core-ci voted on patch set 31 V -1 10/02/22, 20:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31914

  14. Christian Kuhn uploaded patch set 32 10/02/22, 22:39

  15. core-ci voted on patch set 32 V -1 10/02/22, 22:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31917

  16. Christian Kuhn uploaded patch set 33 10/02/22, 22:58

  17. core-ci voted on patch set 33 V +1 10/02/22, 23:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31918

  18. Christian Kuhn uploaded patch set 34 10/02/22, 23:14

  19. core-ci voted on patch set 34 V +1 10/02/22, 23:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31919

  20. Christian Kuhn uploaded patch set 35 10/03/22, 00:14

  21. core-ci voted on patch set 35 V +1 10/03/22, 00:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31920

  22. Christian Kuhn uploaded patch set 36 10/04/22, 14:38

  23. core-ci voted on patch set 36 V +1 10/04/22, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/31983

  24. Christian Kuhn abandoned the change 01/23/23, 17:44

    done with various other patches. abandoning now.
  25. Danilo Caccialanza commented on patch set 36 02/01/23, 08:30

    Questo problema sembra non essere ancora stato risolto: https://github.com/benjaminkott/bootstrap_package/issues/1128 . What patches exactly fix this problem? Is it really a core bug or is it a boostrap_package_bug? Thaks