Review main Merged

75527[TASK] Modernize ext:belog

Torben Hansen CR +2 V +2 Hard +134 −423 updated 09/06/22, 16:04

Commit message

* Use strict function argument and return types where possible
* Removed superfluous argument and return type doc comments
* Replaced deprecated strftime usage
* Removed invalid extension key for LocalizationUtility usage
* Replaced switch statement with match expression
* Removed superfluous type casts

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benni Mack +2
    • Anja Leichsenring +1
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1012

  1. Torben Hansen uploaded patch set 1 08/20/22, 11:58

  2. core-ci voted on patch set 1 V +1 08/20/22, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30332

  3. Nikita Hovratov voted on patch set 1 CR +1 08/22/22, 06:58

  4. Oliver Klee commented on patch set 1 08/22/22, 10:30

    BackendLogController.php:20

    AFAIK, we usually don't import classes from the global namespace, but use them with a backslash instead like this: private \DateTimeImmutable $date;

    LogEntryTest.php:85

    Do these ints relate to error levels? If so, we should use the corresponding constants instead.

    LogEntryTest.php:107

    Let's be more specific: $expected -> $expectedClass (for example) getErrorIconReturnsExpectedResults -> getErrorIconReturnsCorrespondingClass (For naming tests, I recommend this slide: https://speakerdeck.com/oliverklee/test-driven-development-with-phpunit-c87cd9b1-86df-4b61-9f0d-f098f753eb15?slide=33)
  5. Torben Hansen uploaded patch set 2 08/22/22, 18:03

  6. Torben Hansen commented on patch set 1 08/22/22, 18:03

    BackendLogController.php:20 Reply

    Done

    LogEntryTest.php:85 Reply

    No, AFAIK those are error flags. Flag. 0 = message, 1 = error (user problem), 2 = System Error (which should not happen), 3 = security notice (admin)

    LogEntryTest.php:107 Reply

    Done
  7. core-ci voted on patch set 2 V +1 08/22/22, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30358

  8. Oliver Klee commented on patch set 2 CR +1 08/22/22, 21:46

    LogEntryTest.php:85 Reply

    Okay, thanks!
  9. Susi Moog voted on patch set 2 V +1 09/05/22, 09:06

  10. Anja Leichsenring voted on patch set 2 V +1 CR +1 09/06/22, 05:41

  11. Benni Mack voted on patch set 2 V +2 CR +2 09/06/22, 16:04

  12. Benni Mack merged patch set 3 09/06/22, 16:04