75527[TASK] Modernize ext:belog
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Anja Leichsenring +1
-
Verified V +2 Done
- Benni Mack +2
- Anja Leichsenring +1
- Susi Moog +1
- core-ci +1 CI
Issues 1
Files 8
- typo3/sysext/belog/Classes/Controller/BackendLogController.php2+16 −33
- typo3/sysext/belog/Classes/Controller/SystemInformationController.php+3 −6
- typo3/sysext/belog/Classes/Domain/Model/Constraint.php+33 −153
- typo3/sysext/belog/Classes/Domain/Model/LogEntry.php+47 −206
- typo3/sysext/belog/Classes/Domain/Repository/LogEntryRepository.php+1 −21
- typo3/sysext/belog/Classes/ViewHelpers/FormatDetailsViewHelper.php+1 −1
- typo3/sysext/belog/Classes/ViewHelpers/UsernameViewHelper.php+1 −3
- typo3/sysext/belog/Tests/Unit/Domain/Model/LogEntryTest.php5+32 −0
Review log 1012
-
Torben Hansen uploaded patch set 1 08/20/22, 11:58
-
core-ci voted on patch set 1 V +1 08/20/22, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30332
-
Nikita Hovratov voted on patch set 1 CR +1 08/22/22, 06:58
-
Oliver Klee commented on patch set 1 08/22/22, 10:30
LogEntryTest.php:85Do these ints relate to error levels? If so, we should use the corresponding constants instead.LogEntryTest.php:107Let's be more specific: $expected -> $expectedClass (for example) getErrorIconReturnsExpectedResults -> getErrorIconReturnsCorrespondingClass (For naming tests, I recommend this slide: https://speakerdeck.com/oliverklee/test-driven-development-with-phpunit-c87cd9b1-86df-4b61-9f0d-f098f753eb15?slide=33) -
Torben Hansen uploaded patch set 2 08/22/22, 18:03
-
Torben Hansen commented on patch set 1 08/22/22, 18:03
BackendLogController.php:20ReplyDoneLogEntryTest.php:85ReplyNo, AFAIK those are error flags. Flag. 0 = message, 1 = error (user problem), 2 = System Error (which should not happen), 3 = security notice (admin)LogEntryTest.php:107ReplyDone -
core-ci voted on patch set 2 V +1 08/22/22, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30358
-
Oliver Klee commented on patch set 2 CR +1 08/22/22, 21:46
LogEntryTest.php:85ReplyOkay, thanks! -
Susi Moog voted on patch set 2 V +1 09/05/22, 09:06
-
Anja Leichsenring voted on patch set 2 V +1 CR +1 09/06/22, 05:41
-
Benni Mack voted on patch set 2 V +2 CR +2 09/06/22, 16:04
-
Benni Mack merged patch set 3 09/06/22, 16:04
BackendLogController.php:20