Review 11.5 Merged

75531[BUGFIX] Make sure social media images gets processed if needed

Benjamin Franzke CR +2 V +2 Hard +266 −28 updated 08/22/22, 18:30

Commit message

The check if the image has to be processed has been moved to
dedicated methods to enhance readability and testability

The condition still checks if the image is wider than the defined
maximum width. The check if the entire image is used should now be
easier to understand. No offset and 100% of the width and height
of the image correspond to the full image and negated in its entirety.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Hader +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oliver Hader +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benjamin Franzke uploaded patch set 1 08/22/22, 18:01

  2. core-ci voted on patch set 1 V -1 08/22/22, 18:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30357

  3. Oliver Hader uploaded patch set 2 08/22/22, 18:19

  4. Oliver Hader voted on patch set 2 V +1 CR +1 08/22/22, 18:22

  5. core-ci voted on patch set 2 V +1 08/22/22, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30359

  6. Benjamin Franzke voted on patch set 2 V +2 CR +2 08/22/22, 18:30

  7. Benjamin Franzke merged patch set 3 08/22/22, 18:30