75532[BUGFIX] Include pid in field list of BU::getCommonSelectFields
Commit message
Review
-
Code review CR +2 Done
- Christian Kuhn +2
- Benni Mack +1
-
Verified V +2 Done
- Christian Kuhn +2
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 3
Review log 1520
-
Georg Ringer uploaded patch set 1 08/22/22, 20:15
-
Georg Ringer commented on patch set 1 08/22/22, 20:15
This change is ready for review. -
core-ci voted on patch set 1 V -1 08/22/22, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30361
-
Georg Ringer uploaded patch set 2 08/23/22, 07:38
-
core-ci voted on patch set 2 V -1 08/23/22, 07:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30369
-
Benni Mack updated the commit message in patch set 3
V -105/03/23, 09:22 -
core-ci voted on patch set 3 V -1 05/03/23, 10:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41402
-
Benni Mack rebased onto patch set 4
V -107/05/23, 07:19 -
core-ci voted on patch set 4 V -1 07/05/23, 07:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43459
-
Oliver Klee commented on patch set 4 07/05/23, 07:57
Maybe we can include the rationale for this change into the commit message (i.e., why this change is needed/helpful)? -
Benni Mack commented on patch set 4 07/05/23, 10:51
currently can't find a reason why the functionals break -
Christian Kuhn commented on patch set 4 CR -1 07/05/23, 14:53
will work on this soon. -
Christian Kuhn uploaded patch set 5
CR -1V -107/17/23, 09:20 -
Christian Kuhn commented on patch set 5 07/17/23, 09:21
Reply
Done -
Christian Kuhn commented on patch set 5 07/17/23, 09:22
I think we can keep this as bugfix - down to 11.5. v11 needs different test adaptions, though. Added an @todo stating we should get rid of that method entirely, this should be done with a main-only patch, when this here is done. -
core-ci voted on patch set 5 V +1 07/17/23, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44204
-
Christian Kuhn voted on patch set 5 V +1 CR +1 07/17/23, 09:36
-
Benni Mack voted on patch set 5 V +1 CR +1 07/17/23, 09:39
-
Christian Kuhn voted on patch set 5 V +2 CR +2 07/17/23, 10:35
-
Christian Kuhn merged patch set 6 07/17/23, 10:36