Review main Merged

75532[BUGFIX] Include pid in field list of BU::getCommonSelectFields

Georg Ringer CR +2 V +2 Easy +15 −11 updated 07/17/23, 10:36

Commit message

Add the pid to the list of fields which should always be
retrieved when selecting a record. This especially avoid
a PHP warning in FormEngine when workspace records are
overlaid.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1520

  1. Georg Ringer uploaded patch set 1 08/22/22, 20:15

  2. Georg Ringer commented on patch set 1 08/22/22, 20:15

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 08/22/22, 20:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30361

  4. Georg Ringer uploaded patch set 2 08/23/22, 07:38

  5. core-ci voted on patch set 2 V -1 08/23/22, 07:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30369

  6. Benni Mack updated the commit message in patch set 3 V -1 05/03/23, 09:22

  7. core-ci voted on patch set 3 V -1 05/03/23, 10:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41402

  8. Benni Mack rebased onto patch set 4 V -1 07/05/23, 07:19

  9. core-ci voted on patch set 4 V -1 07/05/23, 07:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43459

  10. Oliver Klee commented on patch set 4 07/05/23, 07:57

    Maybe we can include the rationale for this change into the commit message (i.e., why this change is needed/helpful)?
  11. Benni Mack commented on patch set 4 07/05/23, 10:51

    currently can't find a reason why the functionals break
  12. Christian Kuhn commented on patch set 4 CR -1 07/05/23, 14:53

    will work on this soon.
  13. Christian Kuhn uploaded patch set 5 CR -1 V -1 07/17/23, 09:20

  14. Christian Kuhn commented on patch set 5 07/17/23, 09:21

    Reply

    Done
  15. Christian Kuhn commented on patch set 5 07/17/23, 09:22

    I think we can keep this as bugfix - down to 11.5. v11 needs different test adaptions, though. Added an @todo stating we should get rid of that method entirely, this should be done with a main-only patch, when this here is done.
  16. core-ci voted on patch set 5 V +1 07/17/23, 09:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44204

  17. Christian Kuhn voted on patch set 5 V +1 CR +1 07/17/23, 09:36

  18. Benni Mack voted on patch set 5 V +1 CR +1 07/17/23, 09:39

  19. Christian Kuhn voted on patch set 5 V +2 CR +2 07/17/23, 10:35

  20. Christian Kuhn merged patch set 6 07/17/23, 10:36