75536[BUGFIX] List invalid field in FormEngine review
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Jochen Roth +1
-
Verified V +2 Done
- Andreas Kienast +2
- Benjamin Franzke +1
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 4
Review log 1418
-
Andreas Kienast uploaded patch set 1 08/23/22, 11:37
-
Andreas Kienast uploaded patch set 2 08/23/22, 11:39
-
core-ci voted on patch set 2 V +1 08/23/22, 11:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30373
-
core-ci voted on patch set 1 V +1 08/23/22, 11:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30372
-
Oliver Hader commented on patch set 2 08/23/22, 13:01
Hm, hm, hm... not sure how to say it... but, using `classList` to transport runtime-payload does not feel correct. -
Andreas Kienast commented on patch set 2 08/23/22, 13:51
Reply
I know, I feel dirty doing so. I also thought about using a Map object, mapping the fieldId to the list item element but then I'd have to iterate over all entries to get the correct key. -
Andreas Kienast uploaded patch set 3 08/25/22, 05:51
-
core-ci voted on patch set 3 V +1 08/25/22, 06:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30433
-
Benjamin Franzke commented on patch set 3 08/25/22, 11:43
Reply
Maybe use an inline event listener with link.addEventListener('clicl', ...) (which automatically has the context it needs) instead of registering a global one with: $document.on('click', '.' + this.fieldListItemClass, this.switchToField); Should be possible, as objects with class="t3js-field-item" are only dynamically created AFAICS(?) -
Benjamin Franzke commented on patch set 3 08/25/22, 11:52
Reply
Sorry, my suggestion doesn't work, due to: content: $list.wrapAll('<div>').parent().html() -
Benjamin Franzke uploaded patch set 4 08/25/22, 11:59
-
Benjamin Franzke commented on patch set 3 08/25/22, 11:59
Reply
Popover content may also be simply an "Element", so we could use that to pass the list directly in order not to run into the problem that bootstrap's xss sanitizer drops our attributes: https://blog.getbootstrap.com/2019/02/13/bootstrap-4-3-1-and-3-4-1/ Done. -
Benjamin Franzke voted on patch set 4 V +1 CR +1 08/25/22, 12:02
-
core-ci voted on patch set 4 V +1 08/25/22, 12:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30444
-
Andreas Kienast commented on patch set 4 08/25/22, 12:09
Much better, thanks a lot -
Jochen Roth voted on patch set 4 V +1 CR +1 09/05/22, 13:16
-
Andreas Kienast voted on patch set 4 V +2 CR +2 09/05/22, 13:17
-
Andreas Kienast merged patch set 5 09/05/22, 13:17