75537[!!!][TASK] Remove jQuery in PersistentStorage
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Oli Bartsch +1
- Andreas Kienast +1
- core-ci +1 CI
Issues 1
Files 11
- Build/Sources/TypeScript/backend/storage/persistent.ts12+80 −94
- Build/Sources/TypeScript/backend/toolbar/system-information-menu.ts+2 −2
- Build/Sources/TypeScript/backend/page-actions.ts+1 −1
- Build/Sources/TypeScript/recordlist/recordlist.ts+1 −1
- Build/Sources/TypeScript/viewpage/main.ts+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/storage/persistent.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/toolbar/system-information-menu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/page-actions.js+1 −1
- typo3/sysext/core/Documentation/Changelog/12.0/Breaking-98193-PersistentStorageModuleReturnsPromises.rstnew+59 −0
- typo3/sysext/recordlist/Resources/Public/JavaScript/recordlist.js+1 −1
- typo3/sysext/viewpage/Resources/Public/JavaScript/main.js+1 −1
Review log 2026
Show 1 earlier messages
-
Andreas Kienast uploaded patch set 1 08/23/22, 14:01
-
core-ci voted on patch set 1 V +1 08/23/22, 14:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30381
-
Andreas Kienast rebased onto patch set 2 08/24/22, 06:21
-
core-ci voted on patch set 2 V +1 08/24/22, 06:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30400
-
Andreas Kienast uploaded patch set 3 08/25/22, 05:50
-
core-ci voted on patch set 3 V +1 08/25/22, 05:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30432
-
Benjamin Franzke commented on patch set 3 CR -1 08/25/22, 12:19
persistent.ts:70hm.. mixing async/await and .then() in one method feels strange. can we do const response = await new AjaxRequest(..) return await this.resolveResponse(response) instead. (The mixture is so confusing for me, that I'm not even sure whether my example above is correct, but I think it should be) -
Benjamin Franzke commented on patch set 3 08/25/22, 12:47
persistent.ts:37Hm, I think this won't work. value will `undefined` for the first invocation of Persistent.get(), as there is no blocking in this.loadFromServer(). -
Andreas Kienast commented on patch set 3 08/25/22, 15:05
persistent.ts:37ReplyThat's true. The whole class is very special, making refactorings hard here.persistent.ts:70ReplyThis doesn't work. AjaxRequest().get() returns a promise which is resolved via then(), which takes the response as an AjaxResponse object. -
Benjamin Franzke commented on patch set 3 08/25/22, 15:13
persistent.ts:37Replyyup, without making .get() an asynchronous function (which would add new problems for its users for sure), we really have to use plain XMLHttpRequest with async: false if we want to replace jQuery here, since only XMLHttpRequest supports a synchronous mode, while fetch() doesn't allow that. -
Andreas Kienast uploaded patch set 4 08/26/22, 07:08
-
Andreas Kienast uploaded patch set 5 08/26/22, 07:10
-
core-ci voted on patch set 5 V +1 08/26/22, 07:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30453
-
core-ci voted on patch set 4 V +1 08/26/22, 07:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30452
-
Benjamin Franzke uploaded patch set 6 09/08/22, 15:46
-
Benjamin Franzke commented on patch set 6 09/08/22, 15:46
persistent.ts:37ReplyThanks for adapting to XMLHttpRequest.persistent.ts:51ReplyDonepersistent.ts:70Replyok, but following works: const response = await new AjaxRequest(..).post() return this.resolveResponse(response) Adapted the code, hope that's fine. -
Andreas Kienast commented on patch set 6 09/08/22, 15:52
persistent.ts:131Is there a reasoning for the one-time variable? -
core-ci voted on patch set 6 V +1 09/08/22, 15:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30837
-
Andreas Kienast voted on patch set 6 V +1 09/08/22, 15:55
-
Benjamin Franzke commented on patch set 6 09/08/22, 16:18
persistent.ts:131Replywell, probably the missing IDE on my side, wanted to make it explicit, that we need synchronous operation. -
Andreas Kienast commented on patch set 6 09/08/22, 16:20
persistent.ts:131ReplyAck -
Oli Bartsch voted on patch set 6 V +1 CR +1 09/08/22, 17:39
-
Benjamin Franzke voted on patch set 6 V +2 CR +2 09/09/22, 07:00
-
Benjamin Franzke merged patch set 7 09/09/22, 07:00
-
Lina Wolf commented on patch set 7 09/09/22, 15:33
Does this affect https://docs.typo3.org/m/typo3/reference-coreapi/main/en-us/ApiOverview/JavaScript/Modules/DocumentService.html and if yes, how would the example look now? -
Andreas Kienast commented on patch set 7 09/09/22, 15:41
Reply
No, why do you think so?
persistent.ts:51