Review 11.5 Merged

75541[BUGFIX] Avoid invalid property access when persisting extbase objects

Stefan Bürk CR +2 V +2 Easy +28 −5 updated 08/24/22, 11:04

Commit message

With #95819 the detection of Domain Object properties was changed to use
ClassSchema in order to support uninitialized properties is models.
This was not possible with `DomainObjectInterface::_getProperties()`
which used `get_object_vars()` under the hood.

However, with mentioned change, other properties which had been
ignored by `get_object_vars()` were now propagated to persistence,
even if those properties were not configured in TCA. The change in
behavior is considered a regression and is now addressed:

The retrieval of the property value is delayed until after it is
ensured that the property is a persistable property (which asserts
that we are not reading from private properties).

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 3

Review log 46

  1. Stefan Bürk uploaded patch set 1 08/24/22, 10:46

  2. Stefan Bürk rebased onto patch set 2 08/24/22, 10:48

  3. core-ci voted on patch set 1 V -1 08/24/22, 11:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30406

  4. core-ci voted on patch set 2 V +1 08/24/22, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30407

  5. Stefan Bürk voted on patch set 2 V +2 CR +2 08/24/22, 11:04

  6. Stefan Bürk merged patch set 3 08/24/22, 11:04