Review main Merged

75543[BUGFIX] Add resultArray reference for InlineControlContainer customControls hook

Oli Bartsch CR +2 V +2 Easy +2 −0 updated 08/24/22, 14:04

Commit message

InlineControlContainer allows to add custom controls
via a userFunc (hook). However, since the resultArray
was not passed to the userFunc, e.g. no JS module
could be added for the custom control.

This is now fixed by passing the resultArray by reference
to the userFunc.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benjamin Franzke +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 08/24/22, 13:13

  2. core-ci voted on patch set 1 V +1 08/24/22, 13:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30416

  3. Benjamin Franzke voted on patch set 1 V +1 CR +1 08/24/22, 13:28

  4. Christian Kuhn voted on patch set 1 V +1 CR +1 08/24/22, 13:53

  5. Oli Bartsch voted on patch set 1 V +2 CR +2 08/24/22, 14:04

  6. Oli Bartsch merged patch set 2 08/24/22, 14:04