Review 10.4 Abandoned

75544[BUGFIX] Add resultArray reference for InlineControlContainer customControls hook

Oli Bartsch CR 0 V 0 Easy +2 −0 updated 08/24/22, 13:33

Commit message

InlineControlContainer allows to add custom controls
via a userFunc (hook). However, since the resultArray
was not passed to the userFunc, e.g. no JS module
could be added for the custom control.

This is now fixed by passing the resultArray by reference
to the userFunc.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Oli Bartsch uploaded patch set 1 08/24/22, 13:15

  2. Benjamin Franzke commented on patch set 1 08/24/22, 13:26

    Wrong target branch (10.4 instead of 11.5)
  3. core-ci voted on patch set 1 V +1 08/24/22, 13:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30417

  4. Benjamin Franzke voted on patch set 1 CR -1 08/24/22, 13:28

  5. Oli Bartsch abandoned the change 08/24/22, 13:33

  6. Oli Bartsch commented on patch set 1 08/24/22, 13:33

    Reply

    Yep, I pushed the patch to download the patchfile for a 10.4 project. That's why I pushed it as WIP, since private is not possible ATM due to CI.