Review main Merged

75553[TASK] Remove jQuery from EXT:impexp and EXT:info

Andreas Kienast CR +2 V +2 Normal +48 −42 updated 09/05/22, 10:23

Commit message

Some small JavaScripts used in EXT:impexp and EXT:info are migrated to
remove the dependency on jQuery.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1419

  1. Andreas Kienast uploaded patch set 1 08/26/22, 10:36

  2. Andreas Kienast uploaded patch set 2 08/26/22, 10:39

  3. Andreas Kienast uploaded patch set 3 08/26/22, 10:40

  4. core-ci voted on patch set 1 V +1 08/26/22, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30459

  5. core-ci voted on patch set 3 V -1 08/26/22, 10:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30461

  6. core-ci voted on patch set 2 V -1 08/26/22, 10:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30460

  7. Andreas Kienast uploaded patch set 4 08/26/22, 11:30

  8. core-ci voted on patch set 4 V +1 08/26/22, 11:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30462

  9. Benni Mack voted on patch set 4 CR +1 09/05/22, 08:36

  10. Susi Moog commented on patch set 4 09/05/22, 08:39

    import-export.ts:51

    To actually test this in the export case I needed to set "$inputData['action'] = 'export';" in the exportController. The action seems to have gone missing at some point, but the template (and the trigger for this code) still react to {inData.action} == 'export'. The patch itself here is fine, however, we should fix the missing action (or the template) to make sure everything works.
  11. Andreas Kienast commented on patch set 4 09/05/22, 08:41

    import-export.ts:51 Reply

    I've noticed this as well. I think we need a precursor patch here, right?
  12. Susi Moog commented on patch set 4 V +1 CR +1 09/05/22, 09:35

    Andy fixed it <3
  13. Andreas Kienast rebased onto patch set 5 09/05/22, 10:04

  14. Susi Moog voted on patch set 5 V +1 CR +1 09/05/22, 10:04

  15. Susi Moog commented on patch set 5 09/05/22, 10:04

    import-export.ts:51 Reply

    Done
  16. core-ci voted on patch set 5 V +1 09/05/22, 10:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30622

  17. Benni Mack voted on patch set 5 V +1 CR +1 09/05/22, 10:21

  18. Andreas Kienast voted on patch set 5 V +2 CR +2 09/05/22, 10:23

  19. Andreas Kienast merged patch set 6 09/05/22, 10:23