Review main Merged

75557[TASK] Temporarly skip mailer unit test execution with PHP8.1

Stefan Bürk CR +2 V +2 Easy +2 −0 updated 08/27/22, 22:30

Commit message

Symfony recently released new version v5.4.12 and v6.1.4 of the
framework which contains a change in `symfony/mailer` throwing
a TransportException and passing null as 2nd ($code) argument.
This is deprecated since PHP8.1 and emits now a corresponding
depcreaction warning in some circumenstances and breaking one
mailer unit test.

See: https://github.com/symfony/symfony/issues/47402

This change temporarly skips the test for PHP8.1 until the fix
has been merged and released a new version by symfony.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 69

  1. Stefan Bürk uploaded patch set 1 08/27/22, 12:35

  2. core-ci voted on patch set 1 V +1 08/27/22, 12:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30486

  3. Stefan Bürk commented on patch set 1 08/27/22, 12:45

  4. core-ci voted on patch set 1 V -1 08/27/22, 13:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30488

  5. core-ci voted on patch set 1 V +1 08/27/22, 13:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30488

  6. Oliver Klee voted on patch set 1 CR +1 08/27/22, 17:27

  7. Oliver Klee voted on patch set 1 V +1 08/27/22, 17:28

  8. Stefan Bürk commented on patch set 1 V +2 CR +2 08/27/22, 22:30

    Merging this as no-brainer and only test related, to get nightly happy again. Thus bending the rules a bit, hope this is okay.
  9. Stefan Bürk merged patch set 2 08/27/22, 22:30