Review main Abandoned

75561[TASK] Increase new password minimum length in FE

TYPO3com CR 0 V 0 Easy +1 −1 updated 10/17/22, 05:54

Commit message

The original value of 6 was set in 2009, via
39441104649280393f3c54a5bb33b67be294f41a.
This is no longer a sensible value for any kind of system in 2022.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 79

  1. TYPO3com uploaded patch set 1 08/29/22, 15:48

  2. Adrien Crivelli voted on patch set 1 V +1 CR +1 08/29/22, 15:52

  3. core-ci voted on patch set 1 V +1 08/29/22, 15:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30522

  4. Ingo Fabbri commented on patch set 1 CR -1 08/30/22, 11:18

    While I am not strictly against this patch, this change must be considered as breaking change and not just a "task". People not explicitly overriding default-constants values, would suddenly have the new new default of 12 (instead of 6).
  5. Chris Müller commented on patch set 1 09/03/22, 13:11

    See also here for a more flexible approach: https://review.typo3.org/c/Packages/TYPO3.CMS/+/74350
  6. Chris Müller wrote 09/03/22, 13:11

    Removed cc Chris Müller.
  7. Torben Hansen commented on patch set 1 10/17/22, 04:25

    TYPO3 password policies will also be implemented into ext:felogin and the current password validation functionality (extbase validators configured in TypoScript) will be deprecated in v12.
  8. Christian Kuhn commented on patch set 1 10/17/22, 05:53

    ok. thanks for feedback. i hope it's ok to abandon here - a more flexible approach is pending already.
  9. Christian Kuhn abandoned the change 10/17/22, 05:54