Review main Merged

75594[BUGFIX] Allow CSP inline styles in directly requested SVG files

Oliver Hader CR +2 V +2 Easy +12 −4 updated 01/17/23, 20:52

Commit message

Using CSP directive `style-src 'unsafe-inline'` seems to be fine
for directly requested SVG files, since corresponding definitions
are bound to the corresponding resource. Loading styles from any
other external resource is still denied.

Review

  • Code review CR +2 Done
    • Oliver Hader +2
    • Markus Klein +1
    • Torben Hansen +1
    • Frank Nägler +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oliver Hader +2
    • Torben Hansen +1
    • Frank Nägler +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1822

  1. Oliver Hader uploaded patch set 1 08/31/22, 21:03

  2. core-ci voted on patch set 1 V +1 08/31/22, 21:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30564

  3. Oliver Hader voted on patch set 1 CR -1 09/01/22, 08:36

  4. Oliver Hader uploaded patch set 2 09/01/22, 08:38

  5. core-ci voted on patch set 2 V +1 09/01/22, 08:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30573

  6. Torben Hansen voted on patch set 2 V +1 CR +1 09/02/22, 07:03

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 09/02/22, 10:48

  8. Frank Nägler voted on patch set 2 V +1 CR +1 09/20/22, 13:54

  9. Oliver Hader voted on patch set 2 CR -1 09/20/22, 14:28

  10. Oliver Hader commented on patch set 2 09/20/22, 14:29

    Please adjust `\TYPO3\CMS\Core\Controller\FileDumpController::applyContentSecurityPolicy`
  11. Frank Nägler commented on patch set 2 CR -1 09/20/22, 14:35

    Reply

    Good catch; I forgot that this was introduced some days ago.
  12. Oliver Hader uploaded patch set 3 10/05/22, 13:00

  13. core-ci voted on patch set 3 V +1 10/05/22, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/32037

  14. Oliver Hader rebased onto patch set 4 V +1 01/11/23, 13:24

  15. core-ci voted on patch set 4 V +1 01/11/23, 13:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/35684

  16. Markus Klein voted on patch set 4 CR +1 01/11/23, 13:34

  17. Frank Nägler voted on patch set 4 CR +1 01/17/23, 20:06

  18. Frank Nägler voted on patch set 4 V +1 01/17/23, 20:11

  19. Stefan Bürk voted on patch set 4 V +1 CR +1 01/17/23, 20:50

  20. Torben Hansen voted on patch set 4 V +1 CR +1 01/17/23, 20:51

  21. Oliver Hader voted on patch set 4 V +2 CR +2 01/17/23, 20:52

  22. Oliver Hader merged patch set 5 01/17/23, 20:52