Review main Merged

75596[BUGFIX] Add missing outer-container classes for foreign selector types

Nikita Hovratov CR +2 V +2 Easy +2 −2 updated 09/02/22, 10:39

Commit message

With patch #97786 a bug was fixed, to only toggle inline controls in
their own scope. For this a new helper class was introduced and added
for vanilla inline controls. However, there are two other special
inline control types for record selectors. Most commonly known from the
FileSelector for FAL. The helper class is now added there as well.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Henrik Ziegenhain +1
    • Christian Kuhn +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Henrik Ziegenhain +1
    • Jörg Bösche +1
    • Harry Glatz +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 910

  1. Nikita Hovratov uploaded patch set 1 09/01/22, 09:12

  2. Nikita Hovratov commented on patch set 1 09/01/22, 09:17

    Most easily reproducable either in Styleguide "inline FAL" or one of the image, assets, media fields in tt_content by setting: 'minitems' => 1, 'maxitems' => 1,
  3. core-ci voted on patch set 1 V +1 09/01/22, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30574

  4. Jörg Bösche voted on patch set 1 CR +1 09/01/22, 09:37

  5. Henrik Ziegenhain voted on patch set 1 V +1 CR +1 09/01/22, 09:58

  6. Christian Kuhn voted on patch set 1 CR +1 09/01/22, 11:44

  7. Jörg Bösche voted on patch set 1 V +1 09/02/22, 08:29

  8. Harry Glatz commented on patch set 1 V +1 09/02/22, 08:33

    Works for me in 11.5.15
  9. Oli Bartsch voted on patch set 1 V +2 CR +2 09/02/22, 10:38

  10. Oli Bartsch merged patch set 2 09/02/22, 10:39