75598[TASK] Update to PHPStan 1.8.4
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 3
Review log 1420
-
Oliver Klee uploaded patch set 1 09/02/22, 10:07
-
Oliver Klee commented on patch set 1 09/02/22, 10:11
We need to fix the one un-baselineable error first (preferably in a separate change), and I also need to restore the deleted file. (I have no idea why it has gone.) -
core-ci voted on patch set 1 V -1 09/02/22, 10:20 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30587
-
Oliver Klee uploaded patch set 2 09/02/22, 10:22
-
Stefan Bürk updated the commit message in patch set 3 09/02/22, 10:23
-
core-ci voted on patch set 1 V -1 09/02/22, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30587
-
Stefan Bürk updated the commit message in patch set 4 09/02/22, 10:34
-
core-ci voted on patch set 3 V -1 09/02/22, 10:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30589
-
core-ci voted on patch set 4 V -1 09/02/22, 10:49 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30590
-
Christian Kuhn uploaded patch set 5 09/02/22, 14:50
-
core-ci voted on patch set 5 V +1 09/02/22, 14:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30599
-
Oliver Klee commented on patch set 5 09/02/22, 15:11
For the record: This PHPStan version feels slower for me. -
Oliver Klee commented on patch set 5 09/03/22, 08:26
Marking as WIP. I‘ll recycle this change for raising PHPStan to 1.8.4 (or whatever version fixes the performance regression). -
Oliver Klee marked it work in progress 09/03/22, 08:26
-
Oliver Klee uploaded patch set 6 09/03/22, 14:26
-
Oliver Klee marked it ready for review 09/03/22, 14:26
-
Oliver Klee commented on patch set 6 09/03/22, 14:27
Now with PHPStan 1.8.4, the numbers look a lot better on my machine: - 44s first run - 5s subsequent runs (without any code changes) -
core-ci voted on patch set 6 V +1 09/03/22, 14:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30612
-
Oliver Klee marked it work in progress 09/07/22, 19:21
-
Christian Kuhn abandoned the change 09/18/22, 17:01
abandoning for now: phpstan 1.8.5 also suffers from performance issues.