Review 11.5 Merged

75601[TASK] Temporarly avoid PHPStan composer-max tests fails

Stefan Bürk CR +2 V +2 Easy +8 −8 updated 09/02/22, 19:20

Commit message

PHPStan fails with composer max installation due
changes in the detection. Raising the version to
corresponding version leads to abnormal performance
decrease. Thus not an option we can use.

This change pins phpstan to a fixed version to avoid
failing nightlies until the performance issue in the
PHPStan tool has been fixed.

See: https://github.com/phpstan/phpstan/issues/7903

Used commands:

> composer req --dev "phpstan/phpstan":"1.8.2"

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Stefan Bürk uploaded patch set 1 09/02/22, 19:12

  2. core-ci voted on patch set 1 V +1 09/02/22, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30604

  3. Stefan Bürk voted on patch set 1 V +2 CR +2 09/02/22, 19:20

  4. Stefan Bürk merged patch set 2 09/02/22, 19:20