Review main Merged Breaking

75602[!!!][TASK] Remove border and longdescURL properties from IMAGE cObject

Benni Mack CR +2 V +2 Normal +74 −95 updated 09/09/22, 14:07

Commit message

HTML deprecated the "border" attribute and the "longdesc"
attributes which are not set anymore by TYPO3's Frontend.

This mainly relates to "IMAGE" ContentObject.

TypoScript properties
* IMAGE.border
* IMAGE.longdescURL
are no longer used.

The helper function "imgTag" in GraphicalFunctions
is also removed.

Fluid's Thumbnail ViewHelper in Backend
does not allow "longdesc" anymore. As this ViewHelper is
internal, it does not affect public API.

References:
* https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/border
* https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/longDesc

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 14

Review log 1320

  1. Benni Mack uploaded patch set 1 09/05/22, 09:09

  2. core-ci voted on patch set 1 V -1 09/05/22, 09:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30619

  3. Benni Mack updated the commit message in patch set 2 09/05/22, 11:31

  4. core-ci voted on patch set 2 V -1 09/05/22, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30625

  5. Benni Mack uploaded patch set 3 09/09/22, 07:54

  6. core-ci voted on patch set 3 V +1 09/09/22, 08:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30884

  7. Benni Mack uploaded patch set 4 09/09/22, 08:46

  8. Benni Mack updated the commit message in patch set 5 09/09/22, 08:47

  9. core-ci voted on patch set 4 V +1 09/09/22, 08:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30893

  10. core-ci voted on patch set 5 V +1 09/09/22, 08:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30894

  11. Benni Mack uploaded patch set 6 09/09/22, 09:18

  12. core-ci voted on patch set 6 V +1 09/09/22, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30896

  13. Andreas Kienast uploaded patch set 7 09/09/22, 10:19

  14. Andreas Kienast voted on patch set 7 V +1 CR +1 09/09/22, 10:19

  15. core-ci voted on patch set 7 V +1 09/09/22, 10:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30907

  16. Susi Moog voted on patch set 7 V +1 09/09/22, 10:33

  17. Susi Moog voted on patch set 7 CR +1 09/09/22, 10:33

  18. Andreas Kienast voted on patch set 7 V +2 CR +2 09/09/22, 10:35

  19. Andreas Kienast merged patch set 8 09/09/22, 10:36

  20. Benni Mack commented on patch set 8 09/09/22, 14:07

    ImageContentObject.php:136 Unresolved

    forgot to document, that this property is now also not evaluated anymore.