Review main Merged

75603[BUGFIX] Fix condition in EXT:impexp to check for export view

Andreas Kienast CR +2 V +2 Easy +9 −9 updated 09/05/22, 10:01

Commit message

The check for `inData.action` didn't work anymore for a long time as
`action` is not set in the controllers anymore. To check if we're in the
export view, the existing check for `import.mode` is re-used instead.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Susi Moog +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Andreas Kienast uploaded patch set 1 09/05/22, 09:27

  2. Susi Moog voted on patch set 1 V +1 CR +1 09/05/22, 09:32

  3. core-ci voted on patch set 1 V +1 09/05/22, 09:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30620

  4. Benni Mack voted on patch set 1 V +1 CR +1 09/05/22, 09:59

  5. Andreas Kienast voted on patch set 1 V +2 CR +2 09/05/22, 10:01

  6. Andreas Kienast merged patch set 2 09/05/22, 10:01