Review main Merged

75606[FEATURE] Option to configure primary actions in File List

Shehfinaz Kadavil CR +2 V +2 Easy +42 −2 updated 09/09/22, 15:42

Commit message

The primary actions in the file list visible as dedicated buttons in the
table list are now configurable on a backend user basis to show more or
less actions.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 2129

Show 34 earlier messages
  1. Shehfinaz Kadavil uploaded patch set 1 09/05/22, 14:14

  2. core-ci voted on patch set 1 V -1 09/05/22, 14:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30628

  3. Benni Mack commented on patch set 1 09/05/22, 14:34

    Thanks for the patch, I added some remarks

    DefaultConfiguration.php:1269

    I would not set this option in defaultConfiguration (instead provide the defaults in the PHP class directly) and only document this option in the RST (as you did).

    Feature-97821-OptionToConfigureDefaultIconsInFileList.rst:14

    do you want to give an example of the option ``` Example: options.file_list.defaultIcons = view,metadata,copy,cut,translations,delete ``` and maybe a list of icons we can set?

    FileList.php:1104

    please use the short-hand array syntax-

    FileList.php:1106

    you can use $this->getBackendUser() instead of $GLOBALS['BE_USER']. Also, we use `if ($userTsConfig['options.']['file_list.']['defaultIcons'] ?? false)` to avoid PHP 8 errors.

    FileList.php:1108

    we use single quotes, also we should use GeneralUtility::trimExplode() instead here.
  4. Shehfinaz Kadavil uploaded patch set 2 09/06/22, 09:23

  1. Shehfinaz Kadavil commented on patch set 2 09/06/22, 09:26

    Thanks for the feedback.

    DefaultConfiguration.php:1269 Reply

    Done

    Feature-97821-OptionToConfigureDefaultIconsInFileList.rst:14 Reply

    Sorry, I forgot to provide the example. Will add the example in the next commit.

    FileList.php:1104 Reply

    Done

    FileList.php:1106 Reply

    Done

    FileList.php:1108 Reply

    Done
  2. core-ci voted on patch set 2 V -1 09/06/22, 09:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30642

  3. Benni Mack commented on patch set 2 09/06/22, 09:34

    FileList.php:1107

    try running ./Build/Scripts/cglFixMyCommit.sh which then fixes all indention problems, with PHP-CS-Fixer and your tests should become green
  4. Shehfinaz Kadavil uploaded patch set 3 09/06/22, 09:37

  5. Shehfinaz Kadavil commented on patch set 2 09/06/22, 09:37

    Feature-97821-OptionToConfigureDefaultIconsInFileList.rst:14 Reply

    Done

    FileList.php:1107 Reply

    Thanks
  6. core-ci voted on patch set 3 V +1 09/06/22, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30644

  7. Andreas Kienast commented on patch set 3 V -1 CR -1 09/06/22, 09:59

    Two issues I noticed while testing: * Removing "translations" from the configuration renders a menu item in the "dotted" menu without a label * Adding "cut" and "copy" to the configuration renders an empty section in the "dotted" menu

    Feature-97821-OptionToConfigureDefaultIconsInFileList.rst:15

    Empty line before this one

    Feature-97821-OptionToConfigureDefaultIconsInFileList.rst:16

    FileList.php:1104

    I think we could move the whole $defaultIcon block outside this foreach() loop.

    FileList.php:1107

    Missing space after =

    FileList.php:1111

    Please provide "true" as 3rd argument.
  8. Shehfinaz Kadavil uploaded patch set 4 09/06/22, 14:09

  9. Shehfinaz Kadavil commented on patch set 4 09/06/22, 14:15

    Reply

    Hope it is resolved now

    Feature-97821-OptionToConfigureDefaultIconsInFileList.rst:15 Reply

    Done

    Feature-97821-OptionToConfigureDefaultIconsInFileList.rst:16 Reply

    Done

    FileList.php:1104 Reply

    Done

    FileList.php:1107 Reply

    Done

    FileList.php:1111 Reply

    Done
  10. core-ci voted on patch set 4 V +1 09/06/22, 14:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30652

  11. Andreas Kienast commented on patch set 4 V -1 09/06/22, 15:18

    The issue regarding the "translations" button is still valid.
  12. Shehfinaz Kadavil uploaded patch set 5 09/07/22, 08:06

  13. core-ci voted on patch set 5 V -1 09/07/22, 08:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30706

  14. Andreas Kienast rebased onto patch set 6 09/07/22, 08:29

  15. core-ci voted on patch set 6 V +1 09/07/22, 08:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30708

  16. Andreas Kienast uploaded patch set 7 09/09/22, 09:28

  17. Shehfinaz Kadavil commented on patch set 7 09/09/22, 09:31

    Thanks for the change. It is more clear now.
  18. Andreas Kienast uploaded patch set 8 09/09/22, 09:33

  19. core-ci voted on patch set 7 V +1 09/09/22, 09:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30898

  20. Benni Mack voted on patch set 8 V +1 CR +1 09/09/22, 09:36

  21. core-ci voted on patch set 8 V +1 09/09/22, 09:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30900

  22. Andreas Kienast voted on patch set 8 V +2 CR +2 09/09/22, 09:43

  23. Andreas Kienast merged patch set 9 09/09/22, 09:43

  24. Lina Wolf commented on patch set 9 09/09/22, 15:25

    The Changelog say "The actions that can be added are `view`, `metadata`, `copy` and `cut`" however the example mentions `delete` and `translations` is in the default values
  25. Andreas Kienast commented on patch set 9 09/09/22, 15:42

    Reply

    "translations" cannot be removed and "deleted" was forgotten.