Review 11.5 Merged

75612[BUGFIX] List invalid field in FormEngine review

Andreas Kienast CR +2 V +2 Normal +54 −63 updated 09/06/22, 09:48

Commit message

The FormEngine review module broke with the introduction of Bootstrap 5
due to changed API of its Popover module.

Our internal Popover wrapper is now used to render the list of failed
fields again. This also introduces another bugfix in the Popover wrapper
which updates the Popover's content once it was rendered already.

Additionally, a nasty workaround is added: previously, the field id was
stored as a data attribute to the list item in the validation list.
Somewhere in the Popover > Bootstrap > PopperJS handling, those custom
data attributes are removed before rendering the HTML. To circumvent
this issue, the field is now added as last element in the `classList`
DOMTokenList for later use.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 46

  1. Andreas Kienast uploaded patch set 1 09/06/22, 08:56

  2. core-ci voted on patch set 1 V -1 09/06/22, 09:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30641

  3. Andreas Kienast uploaded patch set 2 09/06/22, 09:35

  4. core-ci voted on patch set 2 V +1 09/06/22, 09:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30643

  5. Andreas Kienast voted on patch set 2 V +2 CR +2 09/06/22, 09:48

  6. Andreas Kienast merged patch set 3 09/06/22, 09:48