Review main Merged

75614[BUGFIX] Correct Backend Scaffold

Benjamin Kott CR +2 V +2 Hard +238 −172 updated 12/12/22, 19:05

Commit message

During the migration to bootstrap the scaffold was reworked and is now flowing
incorrectly. The introduction flex on the body has multiple side effects, for example
incorrect layering of modals that are anchored directly on the body.

This patch aims to reduce the differences on different implementations of the
scaffold, as well as removing the flex bugs.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 16

Review log 911

  1. Benjamin Kott uploaded patch set 1 09/06/22, 13:32

  2. core-ci voted on patch set 1 V -1 09/06/22, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30648

  3. Benjamin Kott uploaded patch set 2 09/06/22, 14:06

  4. core-ci voted on patch set 2 V +1 09/06/22, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30651

  5. Benni Mack voted on patch set 2 CR +1 09/06/22, 15:55

  6. Benni Mack voted on patch set 2 V +1 09/06/22, 17:12

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 09/06/22, 17:58

  8. Georg Ringer voted on patch set 2 V +2 CR +2 09/06/22, 18:16

  9. Benni Mack voted on patch set 2 V +2 CR +2 09/06/22, 18:16

  10. Georg Ringer merged patch set 3 09/06/22, 18:16

  11. Benjamin Franzke commented on patch set 3 12/12/22, 19:05

    Hm, this patch removed the ability for scaffold-content to be larger than 100% browser height while providing native scrolling via the documents scrollingElement (document.scrollingElement). Sure, that's not used right now, but it was intended for custom-component-element-backend-modules and that's what min-height: calc(100vh - 45px) in scaffold-content was used for. So, before I add patches that change this behaviour again, I would be interested in: * which layering issues did you actually see with body being flexbox? Modals are positioned outside the flow, so flexbox should have no effect. * Where did you see flowing issues ("flowing incorrectly")? (I also checked the forge ticket, but found no details so far, besides it being "incorrect", which I can't follow)