75614[BUGFIX] Correct Backend Scaffold
Commit message
Review
-
Code review CR +2 Done
- Georg Ringer +2
- Benni Mack +2
- Oli Bartsch +1
-
Verified V +2 Done
- Georg Ringer +2
- Benni Mack +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 16
- Build/Sources/Sass/scaffold/_modulemenu.scss+3 −1
- Build/Sources/Sass/scaffold/_scaffold.scss+10 −7
- Build/Sources/TypeScript/backend/module-menu.ts+19 −13
- Build/Sources/TypeScript/install/module/upgrade/upgrade-wizards.ts+4 −3
- Build/Sources/TypeScript/install/install.ts+0 −3
- Build/Sources/TypeScript/install/router.ts+81 −39
- typo3/sysext/backend/Classes/Controller/BackendController.php+2 −3
- typo3/sysext/backend/Resources/Private/Templates/Backend/Main.html+23 −23
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/module-menu.js+1 −1
- typo3/sysext/form/Resources/Public/Css/form.css+1 −1
- typo3/sysext/install/Resources/Private/Templates/Installer/Init.html+1 −1
- typo3/sysext/install/Resources/Private/Templates/Layout/Init.html+1 −3
- typo3/sysext/install/Resources/Private/Templates/Layout/MainLayout.html+89 −71
- typo3/sysext/install/Resources/Public/JavaScript/module/upgrade/upgrade-wizards.js+1 −1
- typo3/sysext/install/Resources/Public/JavaScript/router.js+1 −1
Review log 911
-
Benjamin Kott uploaded patch set 1 09/06/22, 13:32
-
core-ci voted on patch set 1 V -1 09/06/22, 13:44 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30648
-
Benjamin Kott uploaded patch set 2 09/06/22, 14:06
-
core-ci voted on patch set 2 V +1 09/06/22, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/30651
-
Benni Mack voted on patch set 2 CR +1 09/06/22, 15:55
-
Benni Mack voted on patch set 2 V +1 09/06/22, 17:12
-
Oli Bartsch voted on patch set 2 V +1 CR +1 09/06/22, 17:58
-
Georg Ringer voted on patch set 2 V +2 CR +2 09/06/22, 18:16
-
Benni Mack voted on patch set 2 V +2 CR +2 09/06/22, 18:16
-
Georg Ringer merged patch set 3 09/06/22, 18:16
-
Benjamin Franzke commented on patch set 3 12/12/22, 19:05
Hm, this patch removed the ability for scaffold-content to be larger than 100% browser height while providing native scrolling via the documents scrollingElement (document.scrollingElement). Sure, that's not used right now, but it was intended for custom-component-element-backend-modules and that's what min-height: calc(100vh - 45px) in scaffold-content was used for. So, before I add patches that change this behaviour again, I would be interested in: * which layering issues did you actually see with body being flexbox? Modals are positioned outside the flow, so flexbox should have no effect. * Where did you see flowing issues ("flowing incorrectly")? (I also checked the forge ticket, but found no details so far, besides it being "incorrect", which I can't follow)